The ContactPage extension has no tests.
Description
Description
Details
Details
Related Changes in Gerrit:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T186850 Wikimedia-deployed extensions/skins with no PHPUnit coverage | |||
| Resolved | Umherirrender | T186864 ContactPage extension has no PHPUnit tests |
Event Timeline
Comment Actions
phan is just static analysis (which is good!), but doesn't count as test coverage, which are usually PHPUnit tests or parser tests.
Comment Actions
Change 869338 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/ContactPage@master] Start on selenium tests for ContactPage
Comment Actions
Change 869765 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/ContactPage@master] Start on phpunit tests for Special:Contact
Comment Actions
Change 869338 merged by jenkins-bot:
[mediawiki/extensions/ContactPage@master] Start on selenium tests for ContactPage
Comment Actions
Change 869765 abandoned by Dreamy Jazz:
[mediawiki/extensions/ContactPage@master] Start on phpunit tests for Special:Contact
Reason:
I couldn't get the code to test using the merge strategy defined in extension.json. The test was there to see how wfArrayPlus2d works as a merge strategy by directly using it to set the global value. However, I now think that it is probably not worth doing that.