Rearrange back and publish buttons on the translate editor
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Pginer-WMF
	Feb 9 2018, 1:33 PM

Description

Currently in CX2, back and publish buttons are not clearly integrated in the main piece of content (T186873). Integrating these controls as part of the main content page will make it more clear the relationship between the controls and the content they affect.

Current state

Screen Shot 2018-02-09 at 13.12.41 3.png (207×1 px, 42 KB)

Intended state

CX-translation-view.png (187×1 px, 35 KB)

Some considerations:

All translations, the publish button and the "saving" indicator are presented in the same row, at the top of the main content area.
This area will remain sticky when scrolling to keep the publish button visible.
"All translations" button has a chevron icon pointing back.
Top corners have a 2px border radius (except when it becomes sticky).
These adjustments may require to move the editing toolbar to the tools sidebar (T176422).

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Place the publish settings in the translation header	mediawiki/extensions/ContentTranslation	master	+44 -153

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Pginer-WMF	T157457 Align Content Translation with the design style guide
Resolved	Pginer-WMF	T186873 Adjust the layout of the translation editor to emphasise the main content
Resolved	• Petar.petkovic	T186877 Rearrange back and publish buttons on the translate editor

Event Timeline

Pginer-WMF created this task.Feb 9 2018, 1:33 PM

Pginer-WMF mentioned this in T186873: Adjust the layout of the translation editor to emphasise the main content.

Pginer-WMF triaged this task as Medium priority.Feb 13 2018, 7:08 AM

Pginer-WMF moved this task from Needs Triage to CX2 on the ContentTranslation board.Feb 14 2018, 7:58 AM

Change 413707 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] Place the publish settings in the translation header

https://gerrit.wikimedia.org/r/413707

gerritbot added a project: Patch-For-Review.Feb 26 2018, 9:06 AM

Pginer-WMF moved this task from Backlog to Priority backlog on the Language-2018-Jan-Mar board.Feb 27 2018, 9:12 AM

A couple of small details that were not covered by the initial iteration:

The line at the bottom of this header should use Base80 (#EAECF0) as color.
The "all translations" option should use a chevron pointing back as an icon ("previous" in the icon repo)
The "all translations" option should have a 1px vertical separator at the right using Base80 (#EAECF0) as color.
Since the top-right corner of the Publish button is rounded, the white element behind it is needs to have a top-right rounded corner too (otherwise, the surface behind shows a few pixels, as illustrated below).

Nikerabbit moved this task from Priority backlog to In Progress on the Language-2018-Jan-Mar board.Mar 1 2018, 8:00 AM

• Petar.petkovic claimed this task.Mar 1 2018, 12:17 PM

• Petar.petkovic moved this task from In Progress to In Review on the Language-2018-Jan-Mar board.

Change 413707 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Place the publish settings in the translation header

https://gerrit.wikimedia.org/r/413707

• Petar.petkovic moved this task from In Review to QA on the Language-2018-Jan-Mar board.Mar 1 2018, 3:19 PM

• Petar.petkovic removed a project: Patch-For-Review.

Checked cx2-testing - it seems that all specs are in place (there are dome comments on T186882: Customise the editing toolbar in Content Translation to show the most relevant tools waiting @Pginer-WMF review :

• Petar.petkovic moved this task from QA to Done on the Language-2018-Jan-Mar board.Mar 2 2018, 7:01 AM

Great. It looks good. I created a follow-up ticket for a small adjustment: T188700: CX2: Adjust the "all translations" button on the translation editor

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)).Mar 6 2018, 12:01 PM

	F14250305: Screen Shot 2018-03-01 at 9.13.42 PM.png
	Mar 2 2018, 5:15 AM

	F13377570: Screen Shot 2018-02-09 at 13.12.41 3.png
	Feb 9 2018, 1:33 PM

	F14051652: button-round.png
	Feb 27 2018, 9:23 AM

Rearrange back and publish buttons on the translate editorClosed, ResolvedPublicActions