Page MenuHomePhabricator

Rearrange back and publish buttons on the translate editor
Closed, ResolvedPublic

Description

Currently in CX2, back and publish buttons are not clearly integrated in the main piece of content (T186873). Integrating these controls as part of the main content page will make it more clear the relationship between the controls and the content they affect.

Current state

Intended state

Some considerations:

  • All translations, the publish button and the "saving" indicator are presented in the same row, at the top of the main content area.
  • This area will remain sticky when scrolling to keep the publish button visible.
  • "All translations" button has a chevron icon pointing back.
  • Top corners have a 2px border radius (except when it becomes sticky).
  • These adjustments may require to move the editing toolbar to the tools sidebar (T176422).

Event Timeline

Pginer-WMF triaged this task as Normal priority.Feb 13 2018, 7:08 AM

Change 413707 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] Place the publish settings in the translation header

https://gerrit.wikimedia.org/r/413707

A couple of small details that were not covered by the initial iteration:

  • The line at the bottom of this header should use Base80 (#EAECF0) as color.
  • The "all translations" option should use a chevron pointing back as an icon ("previous" in the icon repo)
  • The "all translations" option should have a 1px vertical separator at the right using Base80 (#EAECF0) as color.
  • Since the top-right corner of the Publish button is rounded, the white element behind it is needs to have a top-right rounded corner too (otherwise, the surface behind shows a few pixels, as illustrated below).

Petar.petkovic moved this task from In Progress to In Review on the Language-2018-Jan-Mar board.

Change 413707 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Place the publish settings in the translation header

https://gerrit.wikimedia.org/r/413707

Etonkovidova closed this task as Resolved.Mar 2 2018, 5:15 AM
Etonkovidova added a subscriber: Etonkovidova.

Checked cx2-testing - it seems that all specs are in place (there are dome comments on T186882: Customise the editing toolbar in Content Translation to show the most relevant tools waiting @Pginer-WMF review :

Petar.petkovic moved this task from QA to Done on the Language-2018-Jan-Mar board.Mar 2 2018, 7:01 AM

Great. It looks good. I created a follow-up ticket for a small adjustment: T188700: CX2: Adjust the "all translations" button on the translation editor