Page MenuHomePhabricator

Unify SearchKeywords implementation
Closed, ResolvedPublic

Description

We should try to make all SearchKeywords a subclass of SimpleKeywordFeature.
The reason is to remove and centralize all the parsing logic out of these classes.

Details

Related Gerrit Patches:
mediawiki/extensions/CirrusSearch : masterMake regex keywords SimpleKeywordFeature
mediawiki/extensions/CirrusSearch : masterMake prefix: a SimpleKeyword
mediawiki/extensions/CirrusSearch : masterAdd tests for prefix
mediawiki/extensions/CirrusSearch : masterMake morelike: a simple keyword
mediawiki/extensions/CirrusSearch : masterAdd SimpleKeywordFeature::getFeatureName()
mediawiki/extensions/CirrusSearch : masterHide SimpleKeywordFeature::getValueRegex()
mediawiki/extensions/CirrusSearch : masterMake local: a SimpleKeyword
mediawiki/extensions/CirrusSearch : masterMake prefer-recent a SimpleKeyword

Event Timeline

dcausse triaged this task as Medium priority.Feb 9 2018, 1:51 PM
dcausse created this task.
Restricted Application edited projects, added Discovery-Search; removed Discovery-Search (Current work). · View Herald TranscriptFeb 9 2018, 1:51 PM

Change 408803 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Make prefer-recent a SimpleKeyword

https://gerrit.wikimedia.org/r/408803

Change 409353 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Make local: a SimpleKeyword

https://gerrit.wikimedia.org/r/409353

Change 409389 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Hide SimpleKeywordFeature::getValueRegex()

https://gerrit.wikimedia.org/r/409389

Change 410175 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Add SimpleKeywordFeature::getFeatureName()

https://gerrit.wikimedia.org/r/410175

Change 410176 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Make morelike: a simple keyword

https://gerrit.wikimedia.org/r/410176

Change 410202 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Add tests for prefix

https://gerrit.wikimedia.org/r/410202

Change 408803 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Make prefer-recent a SimpleKeyword

https://gerrit.wikimedia.org/r/408803

Change 409353 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Make local: a SimpleKeyword

https://gerrit.wikimedia.org/r/409353

Change 409389 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Hide SimpleKeywordFeature::getValueRegex()

https://gerrit.wikimedia.org/r/409389

Change 410175 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Add SimpleKeywordFeature::getFeatureName()

https://gerrit.wikimedia.org/r/410175

Change 410176 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Make morelike: a simple keyword

https://gerrit.wikimedia.org/r/410176

Change 410202 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Add tests for prefix

https://gerrit.wikimedia.org/r/410202

Change 410944 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Make prefix: a SimpleKeyword

https://gerrit.wikimedia.org/r/410944

Change 415321 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Make regex keywords SimpleKeywordFeature

https://gerrit.wikimedia.org/r/415321

Change 410944 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Make prefix: a SimpleKeyword

https://gerrit.wikimedia.org/r/410944

Change 415321 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Make regex keywords SimpleKeywordFeature

https://gerrit.wikimedia.org/r/415321

debt closed this task as Resolved.Apr 3 2018, 3:51 PM