Page MenuHomePhabricator
Create Task
Maniphest T186879

Unify SearchKeywords implementation
Closed, ResolvedPublic
Actions

Description

We should try to make all SearchKeywords a subclass of SimpleKeywordFeature.
The reason is to remove and centralize all the parsing logic out of these classes.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/CirrusSearchmaster+610 -125Make regex keywords SimpleKeywordFeature
mediawiki/extensions/CirrusSearchmaster+170 -113Make prefix: a SimpleKeyword
mediawiki/extensions/CirrusSearchmaster+160 -0Add tests for prefix
mediawiki/extensions/CirrusSearchmaster+90 -54Make morelike: a simple keyword
mediawiki/extensions/CirrusSearchmaster+22 -4Add SimpleKeywordFeature::getFeatureName()
mediawiki/extensions/CirrusSearchmaster+1 -1Hide SimpleKeywordFeature::getValueRegex()
mediawiki/extensions/CirrusSearchmaster+79 -25Make local: a SimpleKeyword
mediawiki/extensions/CirrusSearchmaster+70 -23Make prefer-recent a SimpleKeyword
Customize query in gerrit

Related Objects
Search...

Event Timeline

dcausse triaged this task as Medium priority.Feb 9 2018, 1:51 PM
dcausse created this task.
Restricted Application edited projects, added Discovery-Search; removed Discovery-Search (Current work). · View Herald TranscriptFeb 9 2018, 1:51 PM
gerritbot added a comment.Feb 9 2018, 1:54 PM

Change 408803 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Make prefer-recent a SimpleKeyword

https://gerrit.wikimedia.org/r/408803

gerritbot added a project: Patch-For-Review.Feb 9 2018, 1:54 PM
gerritbot added a comment.Feb 9 2018, 3:30 PM

Change 409353 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Make local: a SimpleKeyword

https://gerrit.wikimedia.org/r/409353

dcausse moved this task from needs triage to Current work on the Discovery-Search board.Feb 9 2018, 4:28 PM
dcausse edited projects, added Discovery-Search (Current work); removed Discovery-Search.
dcausse moved this task from Incoming to not in use - please delete on the Discovery-Search (Current work) board.
gerritbot added a comment.Feb 9 2018, 5:38 PM

Change 409389 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Hide SimpleKeywordFeature::getValueRegex()

https://gerrit.wikimedia.org/r/409389

gerritbot added a comment.Feb 13 2018, 1:58 PM

Change 410175 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Add SimpleKeywordFeature::getFeatureName()

https://gerrit.wikimedia.org/r/410175

gerritbot added a comment.Feb 13 2018, 1:58 PM

Change 410176 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Make morelike: a simple keyword

https://gerrit.wikimedia.org/r/410176

gerritbot added a comment.Feb 13 2018, 4:46 PM

Change 410202 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Add tests for prefix

https://gerrit.wikimedia.org/r/410202

gerritbot added a comment.Feb 13 2018, 5:14 PM

Change 408803 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Make prefer-recent a SimpleKeyword

https://gerrit.wikimedia.org/r/408803

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)).Feb 13 2018, 6:00 PM
gerritbot added a comment.Feb 13 2018, 8:47 PM

Change 409353 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Make local: a SimpleKeyword

https://gerrit.wikimedia.org/r/409353

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)); removed MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)).Feb 13 2018, 9:00 PM
gerritbot added a comment.Feb 13 2018, 9:19 PM

Change 409389 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Hide SimpleKeywordFeature::getValueRegex()

https://gerrit.wikimedia.org/r/409389

gerritbot added a comment.Feb 13 2018, 9:37 PM

Change 410175 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Add SimpleKeywordFeature::getFeatureName()

https://gerrit.wikimedia.org/r/410175

gerritbot added a comment.Feb 13 2018, 10:09 PM

Change 410176 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Make morelike: a simple keyword

https://gerrit.wikimedia.org/r/410176

gerritbot added a comment.Feb 13 2018, 10:28 PM

Change 410202 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Add tests for prefix

https://gerrit.wikimedia.org/r/410202

gerritbot added a comment.Feb 15 2018, 3:04 PM

Change 410944 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Make prefix: a SimpleKeyword

https://gerrit.wikimedia.org/r/410944

gerritbot added a comment.Feb 28 2018, 4:21 PM

Change 415321 had a related patch set uploaded (by DCausse; owner: DCausse):
[mediawiki/extensions/CirrusSearch@master] Make regex keywords SimpleKeywordFeature

https://gerrit.wikimedia.org/r/415321

dcausse moved this task from not in use - please delete to Needs review on the Discovery-Search (Current work) board.Feb 28 2018, 5:54 PM
gerritbot added a comment.Feb 28 2018, 6:43 PM

Change 410944 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Make prefix: a SimpleKeyword

https://gerrit.wikimedia.org/r/410944

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)); removed MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)).Mar 6 2018, 11:01 AM
gerritbot added a comment.Mar 14 2018, 9:28 PM

Change 415321 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Make regex keywords SimpleKeywordFeature

https://gerrit.wikimedia.org/r/415321

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)); removed MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)).Mar 14 2018, 11:00 PM
dcausse moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Mar 27 2018, 5:34 PM
debt closed this task as Resolved.Apr 3 2018, 3:51 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL