Add ability to override menu item creation for DropdownInputWidget
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	gabriel-wmde
	Feb 9 2018, 3:55 PM

Description

The changes made in https://gerrit.wikimedia.org/r/#/c/406397/ make it a bit harder to implement custom options for the menu item, e.g. adding unique ids, classes, etc. Since private methods in JS are not really private, we got away with the override in https://gerrit.wikimedia.org/r/#/c/405905/, but I'd advise moving menu item creation to their own public methods.

Details

	Subject	Repo	Branch	Lines +/-
	Extract menu item creation in DropdownInputWidget	oojs/ui	master	+37 -12

Customize query in gerrit

Related Objects

Mentioned In: T167316: Create tests that describe the desired functionality

Event Timeline

gabriel-wmde created this task.Feb 9 2018, 3:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 9 2018, 3:55 PM

gabriel-wmde added a project: JavaScript.Feb 9 2018, 3:56 PM

Change 409355 had a related patch set uploaded (by Gabriel Birke; owner: Gabriel Birke):
[oojs/ui@master] Extract menu item creation in DropdownInputWidget

https://gerrit.wikimedia.org/r/409355

gerritbot added a project: Patch-For-Review.Feb 9 2018, 3:56 PM

gabriel-wmde mentioned this in T167316: Create tests that describe the desired functionality.Feb 9 2018, 4:12 PM

Change 409355 merged by jenkins-bot:
[oojs/ui@master] Extract menu item creation in DropdownInputWidget

https://gerrit.wikimedia.org/r/409355

Volker_E closed this task as Resolved.Mar 7 2018, 12:33 AM

Volker_E assigned this task to gabriel-wmde.

Volker_E triaged this task as Medium priority.

Volker_E moved this task from Backlog to OOUI-0.25.3 on the OOUI board.

Volker_E edited projects, added OOUI (OOUI-0.25.3); removed OOUI.

Volker_E removed a project: Patch-For-Review.

Volker_E removed a subscriber: gerritbot.