Page MenuHomePhabricator

ResourcesTest::testFileExistence fails for ULS files in VisualEditor
Closed, ResolvedPublic1 Estimated Story Points

Description

For about a day now, CI on Wikidata-related repositories has been failing with these errors:

1) ResourcesTest::testFileExistence with data set #1891 ('/home/jenkins/workspace/mwext...ata.js', 'jquery.uls.data', 'lib/ve/lib/jquery.uls/src/jqu...ata.js')
File 'lib/ve/lib/jquery.uls/src/jquery.uls.data.js' referenced by 'jquery.uls.data' must exist.
Failed asserting that file "/home/jenkins/workspace/mwext-testextension-hhvm-composer-jessie/src/extensions/VisualEditor/includes/lib/ve/lib/jquery.uls/src/jquery.uls.data.js" exists.

/home/jenkins/workspace/mwext-testextension-hhvm-composer-jessie/src/tests/phpunit/structure/ResourcesTest.php:23
/home/jenkins/workspace/mwext-testextension-hhvm-composer-jessie/src/tests/phpunit/MediaWikiTestCase.php:420
/home/jenkins/workspace/mwext-testextension-hhvm-composer-jessie/src/maintenance/doMaintenance.php:94

2) ResourcesTest::testFileExistence with data set #1892 ('/home/jenkins/workspace/mwext...ils.js', 'jquery.uls.data', 'lib/ve/lib/jquery.uls/src/jqu...ils.js')
File 'lib/ve/lib/jquery.uls/src/jquery.uls.data.utils.js' referenced by 'jquery.uls.data' must exist.
Failed asserting that file "/home/jenkins/workspace/mwext-testextension-hhvm-composer-jessie/src/extensions/VisualEditor/includes/lib/ve/lib/jquery.uls/src/jquery.uls.data.utils.js" exists.

/home/jenkins/workspace/mwext-testextension-hhvm-composer-jessie/src/tests/phpunit/structure/ResourcesTest.php:23
/home/jenkins/workspace/mwext-testextension-hhvm-composer-jessie/src/tests/phpunit/MediaWikiTestCase.php:420
/home/jenkins/workspace/mwext-testextension-hhvm-composer-jessie/src/maintenance/doMaintenance.php:94

I don’t think it’s related to Wikibase, since it happened on several completely unrelated changes. (example change)

Event Timeline

Change 409408 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Follow-up fa9438e5f: Fix path to back-up data source for non-ULS installs

https://gerrit.wikimedia.org/r/409408

Jdforrester-WMF triaged this task as Unbreak Now! priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF subscribed.

My fault, sorry. Will fail for code using VE in a non-ULS environment (or, in this case, in CI for code that depends on or cross-tests with VE but not ULS).

Change 409408 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Follow-up fa9438e5f: Fix path to back-up data source for non-ULS installs

https://gerrit.wikimedia.org/r/409408