[wmf.20-regression] MinervaNeue - "Uncaught TypeError: Cannot convert undefined or null to object" when search for Special page
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	Etonkovidova
	Feb 9 2018, 9:55 PM

Description

Switch to MinervaNeue skin and enter "Special:" in the Search box. The suggestion list is displayed and the selection can be made.
However, the following Console error will be displayed:

Uncaught TypeError: Cannot convert undefined or null to object
    at hasOwnProperty (<anonymous>)
    at addBinding (<anonymous>:239:1)
    at Watchstar.oo.EventEmitter.on (<anonymous>:239:212)
    at HTMLLIElement.<anonymous> (<anonymous>:576:167)
    at Function.each (https://en.wikipedia.beta.wmflabs.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=minerva&version=14kbqyi:4:939)
    at jQuery.fn.init.each (https://en.wikipedia.beta.wmflabs.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=minerva&version=14kbqyi:2:505)
    at <anonymous>:575:2391
    at fire (https://en.wikipedia.beta.wmflabs.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=minerva&version=14kbqyi:46:617)
    at Object.fireWith [as resolveWith] (https://en.wikipedia.beta.wmflabs.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=minerva&version=14kbqyi:47:824)
    at Object.deferred.(anonymous function) [as resolve] (https://en.wikipedia.beta.wmflabs.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=minerva&version=14kbqyi:51:337)

Developer notes

The error shows when searching for "Special:Nearby".
We only allow the watching of pages which have an id and all special pages by design have no pageid.

So before firing off the watchlist query we should filter out any results which do not have an id.

Acceptance criteria

Watchstar does not show up next to special pages
If all search results are special pages no request to the watch API is made
Pages without ids are not sent to the watch api.

@pmiazga: Not possible to verify without hacking as the watchstar is not present for Special:Articles. Because there is no element to trigger the watchAPI request there is no possibility to send page without id. I call it done

Testing criteria

Can be tested on beta cluster on the mobile website

Details

	Subject	Repo	Branch	Lines +/-
	Don't try to load watch stars for special page search results	mediawiki/extensions/MobileFrontend	master	+18 -1

Customize query in gerrit

Related Objects

Mentioned In: T186147: [BUG][betalabs] "Uncaught TypeError: Cannot convert undefined or null to object" in some searches
Mentioned Here: T186147: [BUG][betalabs] "Uncaught TypeError: Cannot convert undefined or null to object" in some searches

Event Timeline

Etonkovidova created this task.Feb 9 2018, 9:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 9 2018, 9:55 PM

Etonkovidova renamed this task from [wmf.20-regression] MinervaNeue - "Uncaught TypeError: Cannot convert undefined or null to object" when search for Special to [wmf.20-regression] MinervaNeue - "Uncaught TypeError: Cannot convert undefined or null to object" when search for Special page.Feb 9 2018, 9:55 PM

Are we sure this is a regression and this worked in wmf.9? The code hasn't changed in a long time so this surprises me!

Jdlrobson added a project: Web-Team-Backlog.Feb 14 2018, 12:17 AM

Jdlrobson moved this task from Incoming to Upcoming on the Web-Team-Backlog board.

Possible duplicate of T186147.

• Niedzielski moved this task from Needs triage to Triaged on the Mobile board.Feb 14 2018, 4:38 PM

Jdlrobson closed this task as a duplicate of T186147: [BUG][betalabs] "Uncaught TypeError: Cannot convert undefined or null to object" in some searches.Feb 14 2018, 5:03 PM

Etonkovidova closed this task as a duplicate of T186147: [BUG][betalabs] "Uncaught TypeError: Cannot convert undefined or null to object" in some searches.Feb 16 2018, 9:29 PM

dcausse mentioned this in T186147: [BUG][betalabs] "Uncaught TypeError: Cannot convert undefined or null to object" in some searches.Feb 26 2018, 1:42 PM

I've reopend this based on new information. Added developer notes and should be ready for estimation.

Jdlrobson triaged this task as High priority.Feb 27 2018, 5:11 PM

noting another bug:

as a logged in user, search for any special page, example special:nearby
select star to add special page to watchlist
search for any other special page

Observed: all special pages are displayed as being in watchlist

Screen Shot 2018-02-27 at 6.35.21 PM.png (580×552 px, 54 KB)

Jdlrobson updated the task description. (Show Details)Feb 27 2018, 5:37 PM

ovasileva set the point value for this task to 3.Feb 27 2018, 5:41 PM

ovasileva added a project: Readers-Web-Kanbanana-Board-Old.

Jdlrobson moved this task from Upcoming to 2017-18 Q3 on the Web-Team-Backlog board.Feb 27 2018, 8:14 PM

ovasileva moved this task from To Do to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.Feb 28 2018, 6:12 PM

Jdlrobson moved this task from Needs Design Review to Doing on the Readers-Web-Kanbanana-Board-Old board.Feb 28 2018, 9:40 PM

Jdlrobson moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Feb 28 2018, 11:05 PM

Change 415478 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Don't try to load watch stars for special page search results

https://gerrit.wikimedia.org/r/415478

gerritbot added a project: Patch-For-Review.Feb 28 2018, 11:06 PM

Jdrewniak moved this task from Needs Code Review to Needs QA on the Readers-Web-Kanbanana-Board-Old board.Mar 1 2018, 12:51 PM

Change 415478 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Don't try to load watch stars for special page search results

https://gerrit.wikimedia.org/r/415478

Jdlrobson assigned this task to ABorbaWMF.Mar 1 2018, 6:07 PM

pmiazga claimed this task.Mar 1 2018, 6:07 PM

pmiazga added a subscriber: ABorbaWMF.

Jdlrobson reassigned this task from pmiazga to ABorbaWMF.Mar 1 2018, 6:07 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a subscriber: pmiazga.