Page MenuHomePhabricator

Starting translation not working on IE
Closed, ResolvedPublic

Description

Starting translation isn't possible - both IE10 and IE11

Starting translation isn't possible on both Internet Explorer 10 and IE11, not by using "New translation" dialog nor by clicking on item in 'In progress' list. "New translation" dialog is working up until "Start translation" button is clicked. Clicking item on In progress list (assuming you have started translation in some other browser) starts opening translation view, but JS breaks and nothing happens afterwards. This is image from period before T160918 was implemented, but the end result is pretty much the same, so it's probably broken since T166854.


Same JS error prevents both ways of starting translation: jQuery.Deferred Exception: Object doesn't support property or method 'values' (TypeError) in mw.cx.getDefaultTargetNamespace. The method used isn't supported in any of Internet Explorer versions.

Suggestions not working on IE10

When suggestions start loading, featured articles are displayed and loading indicator shown, while rest of suggestions are loaded. When loading of other suggestions is done, while processing items, JS error happens and "Unable to show suggestions" panel is displayed. JS error is jQuery.Deferred Exception: Unable to get property 'listid' of undefined or null (ReferenceTypeError) in CXSuggestionList.prototype.insertSuggestionList while sorting items by ID. This happens because dataset isn't available before IE11.

Details

Related Gerrit Patches:
mediawiki/extensions/ContentTranslation : masterMake translate view accessible on IE10 & IE11
mediawiki/extensions/ContentTranslation : masterFix suggestions on IE10

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 12 2018, 12:21 PM
Petar.petkovic triaged this task as High priority.Feb 12 2018, 12:24 PM

Triaged as high, because this ticket is derived from T173060, which is high priority. Initial ticket was changed to show UI problems, while this one is about how CX on IE is pretty much broken for last 8 months.

When access to translate view is restored, more (UI and functionality) problems are likely to be uncovered.

Change 409929 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Make translate view accessible on IE10+

https://gerrit.wikimedia.org/r/409929

Change 409946 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Fix suggestions on IE10

https://gerrit.wikimedia.org/r/409946

Petar.petkovic updated the task description. (Show Details)

Change 409946 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Fix suggestions on IE10

https://gerrit.wikimedia.org/r/409946

Change 409929 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Make translate view accessible on IE10 & IE11

https://gerrit.wikimedia.org/r/409929

Petar.petkovic moved this task from In Review to QA on the Language-2018-Jan-Mar board.
Petar.petkovic updated the task description. (Show Details)
Etonkovidova closed this task as Resolved.Feb 16 2018, 12:44 AM

Checked in Saucelabs for IE10 and IE11 - the fixes seems to be in place:

  • The list of suggestions with icons is displayed
  • The translation can be started
Petar.petkovic moved this task from QA to Done on the Language-2018-Jan-Mar board.Feb 16 2018, 1:10 AM