Page MenuHomePhabricator
Create Task
Maniphest T187075

Page layout looks off in Monobook after clicking on "Resume editing" and publishing changes afterwards
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

I have reproduced what the title says after following steps for this report on mw.org. Everything goes back to normal after refreshing.
(User reports further weirdness that we can file separately after we get a few more details.)
I don't take any responsibility for emotional or other kind of damage incurred while switching to that skin for testing purposes.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
NWE preview: Avoid skin style clashmediawiki/extensions/VisualEditormaster+4 -0
Customize query in gerrit

Related Objects

Event Timeline

• Elitre created this task.Feb 12 2018, 2:29 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptFeb 12 2018, 2:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Elitre updated the task description. (Show Details)Feb 12 2018, 2:30 PM
Kghbln subscribed.Feb 12 2018, 3:29 PM
Esanders subscribed.Feb 13 2018, 4:15 PM

This is a regression from the code that loads extra stylesheets provided by RESTbase. They ship some vector-specific styles, which obviously clash with monobook.

gerritbot subscribed.Feb 13 2018, 4:23 PM

Change 410198 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] NWE preview: Avoid skin style clash

https://gerrit.wikimedia.org/r/410198

gerritbot added a project: Patch-For-Review.Feb 13 2018, 4:23 PM
gerritbot added a comment.Feb 13 2018, 5:15 PM

Change 410198 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] NWE preview: Avoid skin style clash

https://gerrit.wikimedia.org/r/410198

Jdforrester-WMF closed this task as Resolved.Feb 13 2018, 5:39 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
Jdforrester-WMF edited projects, added VisualEditor-MediaWiki; removed Patch-For-Review.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptFeb 13 2018, 5:39 PM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)).Feb 13 2018, 6:00 PM
• Elitre awarded a token.Feb 14 2018, 11:18 AM
Kghbln added a comment.Feb 16 2018, 5:18 PM

Just tested. Works! Cool! Thank you!

Kghbln awarded a token.Feb 16 2018, 5:19 PM
• Elitre added a comment.Feb 16 2018, 6:07 PM

Thank /you/ for taking the time to report it. It's deeply appreciated. You did it, and, Bang!, they fixed this ;)

Arlolra mentioned this in T185284: Timeless WTE2017 preview has inconsistent styling.Jul 27 2021, 9:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits