Page MenuHomePhabricator

Switch from dieUsage() to dieWithError() in Page Forms
Closed, InvalidPublic

Description

The MediaWiki function dieUsage() is called twice in the file PF_AutocompleteAPI.php. It is deprecated in favor of the new function dieWithError(). Unfortunately, Page Forms is trying to support a range of MediaWiki versions, so it can't simply switch to calling dieWithError() everywhere. Instead, there should be "if" statements, calling method_exists() to determine which one to call.

Event Timeline

Currently, is_callable( array( $this, 'dieWithError' ) ) condition is being used to determine the method that has to be called ( dieUsage() or dieWithError() ) in PF_AutocompleteAPI.php, should I replace it with method_exists( $this, 'dieWithError' ) ?

Oops - I should have checked more carefully; this has already been done. Thanks for finding that. I'm closing this bug as "invalid".