Page MenuHomePhabricator
Create Task
Maniphest T187119

[wmf.20-regression] Uncaught TypeError: $targetTemplate.first(...).cxoverlay is not a function
Closed, ResolvedPublic
Actions

Description

The issue exists cx-testing also.

  1. Go to hewiki
  2. Start translating "McLaren" article from English to Hebrew - "McLaren"
  3. Click on the first template (Infobox F1 team) - the following error will be displayed:

After that, nothing can be done with the article - clicking on paragraphs will not start translation.

Uncaught TypeError: $targetTemplate.first(...).cxoverlay is not a function
    at Object.TemplateTool.static.processTemplate (load.php?debug=false&lang=en&modules=ext.cx.pageselector%2Ctools|ext.cx.tools.card%2Ccategories%2Cdictionary%2Cformatter%2Cgallery%2Cimages%2Cinstructions%2Clink%2Clinter%2Cmanager%2Cmt%2Cmtabuse%2Cpoem%2Creference%2Ctemplate|ext.cx.tools.mt.card|ext.cx.tools.template.card%2Ceditor|mw.cx.widgets.TemplateParamOptionWidget&skin=vector&version=1x4ydwz:115)
    at TemplateTool.static.processBlockTemplate (load.php?debug=false&lang=en&modules=ext.cx.pageselector%2Ctools|ext.cx.tools.card%2Ccategories%2Cdictionary%2Cformatter%2Cgallery%2Cimages%2Cinstructions%2Clink%2Clinter%2Cmanager%2Cmt%2Cmtabuse%2Cpoem%2Creference%2Ctemplate|ext.cx.tools.mt.card|ext.cx.tools.template.card%2Ceditor|mw.cx.widgets.TemplateParamOptionWidget&skin=vector&version=1x4ydwz:117)
    at fire (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=14kbqyi:46)
    at Object.fireWith (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=14kbqyi:47)
    at Object.fire (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=14kbqyi:176)
    at HTMLDivElement.sectionClick (load.php?debug=false&lang=en&modules=easy-deflate.core%2Cdeflate|ext.cx.editor%2Cpublish%2Ctranslation|ext.cx.publish.dialog|ext.cx.tours.publish.init|ext.cx.translation.progress|ext.cx.util.selection|mediawiki.api.edit&skin=vector&version=0nhwff0:47)
    at HTMLDivElement.dispatch (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=14kbqyi:69)
    at HTMLDivElement.elemData.handle (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=14kbqyi:66)
    at Object.trigger (load.php?debug=false&lang=en&modules=jquery%2Cmediawiki|mediawiki.legacy.wikibits&only=scripts&skin=vector&version=14kbqyi:112)
    at HTMLDivElement.<anonymous> (load.php?debug=

Note 1: More examples:

  • https://en.wikipedia.org/wiki/Ernie_Davis - template: Infobox NFL biography
  • https://el.wikipedia.org/wiki/Macintosh - template {{ανακατεύθυνση|Mac|το υποεπίπεδο Ελέγχου Πρόσβασης Μέσου στο [[μοντέλο αναφοράς OSI]]|υποεπίπεδο MAC|τις διευθύνσεις κόμβων του υποεπιπέδου MAC|διεύθυνση MAC}}

Note 2: the issue does not happen with all Infobox template - e.g. https://en.wikipedia.org/wiki/Tesla,_Inc. - the template Infobox company won't produce any error.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add ext.cx.widgets.overlay dependency to template editormediawiki/extensions/ContentTranslationwmf/1.31.0-wmf.20+1 -0
Add ext.cx.widgets.overlay dependency to template editormediawiki/extensions/ContentTranslationmaster+1 -0
Customize query in gerrit

Event Timeline

Etonkovidova created this task.Feb 12 2018, 8:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 12 2018, 8:33 PM
Etonkovidova updated the task description. (Show Details)Feb 12 2018, 10:11 PM
Etonkovidova updated the task description. (Show Details)Feb 12 2018, 11:32 PM
Etonkovidova added a subscriber: KartikMistry.Feb 13 2018, 3:25 AM
gerritbot subscribed.Feb 13 2018, 4:33 AM

Change 410103 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] Add ext.cx.widgets.overlay dependency to template editor

https://gerrit.wikimedia.org/r/410103

gerritbot added a project: Patch-For-Review.Feb 13 2018, 4:33 AM
santhosh claimed this task.Feb 13 2018, 4:33 AM
santhosh triaged this task as High priority.

Regression from https://gerrit.wikimedia.org/r/c/406599/

santhosh added a project: Language-2018-Jan-Mar.Feb 13 2018, 4:44 AM
gerritbot added a comment.Feb 13 2018, 4:58 AM

Change 410103 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Add ext.cx.widgets.overlay dependency to template editor

https://gerrit.wikimedia.org/r/410103

gerritbot added a comment.Feb 13 2018, 5:00 AM

Change 410105 had a related patch set uploaded (by KartikMistry; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@wmf/1.31.0-wmf.20] Add ext.cx.widgets.overlay dependency to template editor

https://gerrit.wikimedia.org/r/410105

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)).Feb 13 2018, 5:00 AM
Etonkovidova added a comment.Feb 13 2018, 6:23 AM

Checked in cx-testing. The error is gone and the page seems to be translatable after clicking on the template. However, there is a persistent "An error occurred while saving the page." and the Console displays:

POST http://cxserver2.wmflabs.org/v1/mt/en/yi/Yandex 403 (Forbidden)
load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=08hbojf:130 
POST http://cx-testing.wmflabs.org/api.php 500 (Internal Server Error)

The translation cannot be saved. The production seems to fine now in terms of saving/loading started translation, although there were some complaints about not being able to load or save previously started translations.

KartikMistry added a comment.Feb 13 2018, 6:24 AM
In T187119#3966111, @Etonkovidova wrote:

Checked in cx-testing. The error is gone and the page seems to be translatable after clicking on the template. However, there is a persistent "An error occurred while saving the page." and the Console displays:

POST http://cxserver2.wmflabs.org/v1/mt/en/yi/Yandex 403 (Forbidden)
load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=08hbojf:130 
POST http://cx-testing.wmflabs.org/api.php 500 (Internal Server Error)

The translation cannot be saved. The production seems to fine now in terms of saving/loading started translation, although there were some complaints about not being able to load or save previously started translations.

cx-testing instances are not configured to use Yandex. Can you try with Apertium MT?

Etonkovidova added a comment.Feb 13 2018, 6:34 AM

@KartikMistry Using Apertium- http://cx-testing.wmflabs.org/index.php?title=Special:ContentTranslation&page=Campbell%20(California)&from=es&to=en&targettitle=Campbell%20(California) - POST http://cx-testing.wmflabs.org/api.php 500 (Internal Server Error)

Even for simple articles without any templates: http://cx-testing.wmflabs.org/index.php?title=Special:ContentTranslation&page=Cat%20(Unix)&from=es&to=en&targettitle=Cat%20(Unix) - the same 500 error.

KartikMistry added a comment.Feb 13 2018, 6:42 AM
In T187119#3966125, @Etonkovidova wrote:

@KartikMistry Using Apertium- http://cx-testing.wmflabs.org/index.php?title=Special:ContentTranslation&page=Campbell%20(California)&from=es&to=en&targettitle=Campbell%20(California) - POST http://cx-testing.wmflabs.org/api.php 500 (Internal Server Error)

Even for simple articles without any templates: http://cx-testing.wmflabs.org/index.php?title=Special:ContentTranslation&page=Cat%20(Unix)&from=es&to=en&targettitle=Cat%20(Unix) - the same 500 error.

Can you test again? Ignore Yandex (403) errors as of now. 500 should be fixed (cronjob was stuck and core was not updated to latest).

gerritbot added a comment.Feb 13 2018, 2:13 PM

Change 410105 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@wmf/1.31.0-wmf.20] Add ext.cx.widgets.overlay dependency to template editor

https://gerrit.wikimedia.org/r/410105

Stashbot subscribed.Feb 13 2018, 2:25 PM

Mentioned in SAL (#wikimedia-operations) [2018-02-13T14:25:44Z] <zfilipin@tin> Synchronized php-1.31.0-wmf.20/extensions/ContentTranslation/extension.json: SWAT: [[gerrit:410105|Add ext.cx.widgets.overlay dependency to template editor (T187119)]] (duration: 00m 55s)

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)); removed MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)).Feb 13 2018, 3:00 PM
Etonkovidova added a comment.Feb 13 2018, 10:32 PM

Checked in testwiki (wmf.21) - the cases (articles with infobox template) mentioned in the ticket description do not produce error; the content is translatable and the saved started translation is loaded successfully.

@KartikMistry - yes, cx-testing looks fine.

Etonkovidova closed this task as Resolved.Feb 13 2018, 10:33 PM
KartikMistry moved this task from Backlog to Done on the Language-2018-Jan-Mar board.Feb 14 2018, 3:59 AM
Nikerabbit removed a project: Patch-For-Review.Feb 14 2018, 8:35 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits