Page MenuHomePhabricator

/srv/mediawiki-staging/scap/plugins/ had a live hack
Closed, ResolvedPublic


For some reason, /srv/mediawiki-staging was in a dirty state on tin.eqiad.wmnet:
-rw-rw-r-- 1 thcipriani wikidev 4180 Feb 12 17:19 scap/plugins/

--- a/scap/plugins/
+++ b/scap/plugins/
@@ -97,7 +97,10 @@ class Clean(main.AbstractSync):
     def _maybe_delete(self, path):
         if os.path.exists(path):
-            shutil.rmtree(path)
+            if os.path.isdir(path):
+                shutil.rmtree(path)
+            else:
+                os.remove(path)
                 'Unable to delete %s, already missing', path)

Event Timeline

Mentioned in SAL (#wikimedia-operations) [2018-02-13T08:37:17Z] <hashar> tin.eqiad.wmnet: removing live hack in /srv/mediawiki-staging/scap/plugins/ | T187160

thcipriani assigned this task to hashar.
thcipriani added a subscriber: demon.

I guess somehow I created that file initially, but I haven't edited it in a good long while. I see @demon pruned wmf.17 last night so this was likely a hotfix that wasn't cleaned:

Thank you for the cleanup @hashar !

Ugh, should've committed it instead....