Page MenuHomePhabricator
Create Task
Maniphest T187170

Font changer does not save changes consistently on mobile web
Closed, ResolvedPublic0 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
ovasileva
Feb 13 2018, 11:00 AM
Tags
Referenced Files
F34917232: Screen Shot 2022-01-13 at 9.38.28 AM.png
Jan 13 2022, 5:53 PM
F34917253: Screen Shot 2022-01-13 at 9.45.37 AM.png
Jan 13 2022, 5:53 PM
F34917255: Screen Shot 2022-01-13 at 9.46.03 AM.png
Jan 13 2022, 5:53 PM
F34917223: Screen Shot 2022-01-13 at 9.32.10 AM.png
Jan 13 2022, 5:53 PM
F34917259: Screen Shot 2022-01-13 at 9.48.45 AM.png
Jan 13 2022, 5:53 PM
F34917251: Screen Shot 2022-01-13 at 9.45.07 AM.png
Jan 13 2022, 5:53 PM
F34917230: Screen Shot 2022-01-13 at 9.38.01 AM.png
Jan 13 2022, 5:53 PM
F34917261: Screen Shot 2022-01-13 at 9.49.12 AM.png
Jan 13 2022, 5:53 PM
View All 15 Files
Subscribers
ABorbaWMF
Aklapper
Edtadros
Jdlrobson
ovasileva

Description

Background

Initially reported by @ABorbaWMF in T185166: [Spike, 2hrs] Can we detect back button clicks after changing font

Steps to recreate

  1. Load an article on the mobile site in iOS Safari
  2. Tap settings in the main menu
  3. Change font to X-large
  4. Tap back (browser hardware button) and view the article
  5. Tap settings
  6. Change to Small
  7. Tap back and view the article

Observed Behavior
Font does not change on back button

Reported on the following devices/browsers

  • iPhone X iOS 11 - Safari
  • iPhone 8 iOS 11 - Safari
  • iPhone 6s iOS 9 - Safari & Chrome & Firefox - Does NOT happen on UC Browser

Developer notes

As noted in the original bug (T185166) this is an upstream problem with the iOS platform and there doesn't appear to be anything we can do our end except report this upstream.

QA Results - Prod

ACStatusDetails
1✅T187170#7620135

Details

SubjectRepoBranchLines +/-
Fix font changer with back/forward cachemediawiki/extensions/MobileFrontendmaster+43 -14
Customize query in gerrit

Related Objects

Event Timeline

ovasileva created this task.Feb 13 2018, 11:00 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 13 2018, 11:00 AM
ovasileva triaged this task as Medium priority.Feb 13 2018, 11:01 AM
ovasileva mentioned this in T185166: [Spike, 2hrs] Can we detect back button clicks after changing font .
ovasileva moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.
Jdlrobson changed the task status from Open to Stalled.Feb 13 2018, 6:43 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Needs Prioritization to Tracking on the Web-Team-Backlog board.Feb 22 2018, 10:15 PM
Jdlrobson edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog.
ovasileva added a subscriber: Jdlrobson.Feb 23 2018, 2:47 PM

@Jdlrobson - did we end up reporting this?

Aklapper added a project: Upstream.May 12 2020, 9:38 PM
Jdlrobson edited projects, added Web-Team-Backlog (Needs Prioritization (Tech)); removed Web-Team-Backlog (Tracking).EditedNov 12 2021, 10:21 PM

Since we don't have consistent instructions to replicate this we can't create a minimal test case just yet. If we can do that we can file it at https://bugs.webkit.org

I suspect that when hitting back Apple's cache is kicking in, and it's ignoring changes to localStorage.

Not really sure how to fix this.

Is is still a problem?

gerritbot added a comment.Nov 30 2021, 5:39 PM

Change 742771 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] Fix font changer with back/forward cache

https://gerrit.wikimedia.org/r/742771

gerritbot added a project: Patch-For-Review.Nov 30 2021, 5:39 PM
Jdlrobson changed the task status from Stalled to Open.Nov 30 2021, 5:40 PM
Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Needs Prioritization (Tech)), Upstream.

@ovasileva this still seems to be a problem, but only for users changing the font size multiple times, but looks like it can be fixed by the above patch. This was also a good time to clean up that code.

Pushing back to you to prioritize reviewing and merging that patch.

Jdlrobson moved this task from Incoming to Not ready to estimate on the Web-Team-Backlog board.Nov 30 2021, 5:40 PM
Jdlrobson edited projects, added MobileFrontend; removed Patch-For-Review, Mobile-Web-Settings.Dec 1 2021, 8:04 PM
ovasileva moved this task from Not ready to estimate to Current Fiscal Year on the Web-Team-Backlog board.Dec 6 2021, 4:18 PM
gerritbot added a comment.Dec 21 2021, 5:34 PM

Change 742771 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Fix font changer with back/forward cache

https://gerrit.wikimedia.org/r/742771

Jdlrobson renamed this task from Font changer does not save changes consistently to Font changer does not save changes consistently on mobile web.Dec 21 2021, 5:35 PM
Jdlrobson assigned this task to Edtadros.
Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Web-Team-Backlog.
Jdlrobson set the point value for this task to 0.
Jdlrobson moved this task from Needs Analysis to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson updated the task description. (Show Details)
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.16; 2022-01-03).Dec 21 2021, 6:00 PM
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jan 11 2022, 2:25 AM
Edtadros reassigned this task from Edtadros to ovasileva.Jan 13 2022, 5:53 PM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device: devices below on browserstack

Test Artifact(s):

QA Steps
  1. Load an article on the mobile site in iOS Safari
  2. Tap settings in the main menu
  3. Change font to X-large
  4. Tap back (browser hardware button) and view the article
  5. Tap settings
  6. Change to Small
  7. Tap back and view the article
  8. Observed Behavior
  9. ✅ AC1: Font does not change on back button

Reported on the following devices/browsers

iPhone X iOS 11 - Safari

RegularLargeSmall
Screen Shot 2022-01-13 at 9.32.10 AM.png (908×534 px, 206 KB)
Screen Shot 2022-01-13 at 9.32.41 AM.png (909×534 px, 255 KB)
Screen Shot 2022-01-13 at 9.33.05 AM.png (909×534 px, 209 KB)

iPhone 8 iOS 11 - Safari

RegularLargeSmall
Screen Shot 2022-01-13 at 9.38.01 AM.png (793×537 px, 284 KB)
Screen Shot 2022-01-13 at 9.38.28 AM.png (854×541 px, 295 KB)
Screen Shot 2022-01-13 at 9.38.57 AM.png (856×538 px, 280 KB)

iPhone 6s iOS 9 - Safari & Chrome & Firefox - Does NOT happen on UC Browser
Safari

RegularLargeSmall
Screen Shot 2022-01-13 at 9.41.19 AM.png (840×524 px, 194 KB)
Screen Shot 2022-01-13 at 9.41.54 AM.png (845×528 px, 217 KB)
Screen Shot 2022-01-13 at 9.42.22 AM.png (842×527 px, 207 KB)

Chrome

RegularLargeSmall
Screen Shot 2022-01-13 at 9.45.07 AM.png (827×530 px, 237 KB)
Screen Shot 2022-01-13 at 9.45.37 AM.png (828×527 px, 237 KB)
Screen Shot 2022-01-13 at 9.46.03 AM.png (829×528 px, 256 KB)

Firefox

RegularLargeSmall
Screen Shot 2022-01-13 at 9.48.45 AM.png (843×528 px, 215 KB)
Screen Shot 2022-01-13 at 9.49.12 AM.png (844×529 px, 245 KB)
Screen Shot 2022-01-13 at 9.49.42 AM.png (849×531 px, 234 KB)
Edtadros updated the task description. (Show Details)Jan 13 2022, 5:53 PM
ovasileva closed this task as Resolved.Jan 17 2022, 2:27 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL