3D badge not always being added
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matthiasmullie
	Feb 13 2018, 12:57 PM

Description

The '3D' badge is not always being added to the images.
This happens because the node that forms the '3D' badge is being moved around the thumbs on the screen and could end up being on the main image or one of the revision thumbs.
Patch coming up.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix badge, yet again	mediawiki/extensions/3D	wmf/1.31.0-wmf.20	+32 -28
	Fix badge, yet again	mediawiki/extensions/3D	master	+32 -28

Customize query in gerrit

Related Objects

Mentioned In: rETHR030423acbb36: Fix badge, yet again
rETHRa75e1e0761dd: Fix badge, yet again

Event Timeline

matthiasmullie created this task.Feb 13 2018, 12:57 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 13 2018, 12:57 PM

Change 410165 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/3D@master] Fix badge, yet again

https://gerrit.wikimedia.org/r/410165

gerritbot added a project: Patch-For-Review.Feb 13 2018, 12:57 PM

matthiasmullie mentioned this in rETHRa75e1e0761dd: Fix badge, yet again.Feb 13 2018, 12:57 PM

matthiasmullie moved this task from To Do to Code Review on the Multimedia-Team-Working-Board board.Feb 13 2018, 12:58 PM

Change 410165 merged by jenkins-bot:
[mediawiki/extensions/3D@master] Fix badge, yet again

https://gerrit.wikimedia.org/r/410165

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)).Feb 13 2018, 3:00 PM

Change 410204 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/3D@wmf/1.31.0-wmf.20] Fix badge, yet again

https://gerrit.wikimedia.org/r/410204

matthiasmullie mentioned this in rETHR030423acbb36: Fix badge, yet again.Feb 13 2018, 5:11 PM

• Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.Feb 13 2018, 7:16 PM

Change 410204 merged by jenkins-bot:
[mediawiki/extensions/3D@wmf/1.31.0-wmf.20] Fix badge, yet again

https://gerrit.wikimedia.org/r/410204

matthiasmullie moved this task from Code Review to Needs QA on the Multimedia-Team-Working-Board board.Feb 14 2018, 2:12 PM

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)); removed MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)).Feb 14 2018, 3:00 PM

• Ramsey-WMF closed this task as Resolved.Feb 21 2018, 5:30 PM