Page MenuHomePhabricator
Create Task
Maniphest T187282

"Uncaught TypeError: Cannot read property 'top' of null" appears while switching to wikitext diff from visual diff after changing the link target of a link that has a label
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  1. Create an external link.
  2. Click on Edit again.
  3. Click the button "Add label".
  4. Once the label gets added, reopen the link inspector again.
  5. Change the external link.
  6. Click on "Publish Changes".
  7. Switch from visual diff to wikitext diff.

Observe that, there is an error in the console: Uncaught TypeError: Cannot read property 'top' of null

Screen Shot 2018-02-13 at 5.18.48 PM.png (768×1 px, 194 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
MWSaveDialog: Another check to see if visual diff is still visiblemediawiki/extensions/VisualEditormaster+2 -1
Customize query in gerrit

Event Timeline

Ryasmeen created this task.Feb 14 2018, 1:31 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 14 2018, 1:31 AM
Esanders moved this task from To Triage to Current work on the VisualEditor board.Feb 16 2018, 3:17 PM
Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.
Esanders moved this task from Incoming to In progress on the VisualEditor (Current work) board.
gerritbot subscribed.Feb 16 2018, 3:23 PM

Change 411261 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] MWSaveDialog: Another check to see if visual diff is still visible

https://gerrit.wikimedia.org/r/411261

gerritbot added a project: Patch-For-Review.Feb 16 2018, 3:23 PM
• Deskana assigned this task to Esanders.Feb 16 2018, 3:32 PM
gerritbot added a comment.Feb 16 2018, 5:15 PM

Change 411261 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] MWSaveDialog: Another check to see if visual diff is still visible

https://gerrit.wikimedia.org/r/411261

Jdforrester-WMF moved this task from In progress to Code review on the VisualEditor (Current work) board.Feb 16 2018, 5:32 PM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)).Feb 16 2018, 6:00 PM
Jdforrester-WMF moved this task from Code review to Product owner review on the VisualEditor (Current work) board.Feb 20 2018, 6:40 PM
Jdforrester-WMF removed a project: Patch-For-Review.Feb 20 2018, 6:57 PM
Ryasmeen added a project: Verified.Feb 21 2018, 9:04 PM
Ryasmeen added a project: Verified-in-Phase0.
Ryasmeen closed this task as Resolved.Feb 21 2018, 9:19 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptFeb 21 2018, 9:19 PM
Ryasmeen moved this task from To be Verified to Verified on the User-Ryasmeen board.Mar 19 2018, 10:13 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits