Page MenuHomePhabricator
Create Task
Maniphest T187283

Improve ping limiter error message
Open, In Progress, Needs TriagePublic
Actions

Description

Ping limiter error messages (actionthrottledtext) say to wait a few minutes, but we use the ping limiter to throttle daily rates for some things. The message should tell you how much you need to wait.

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+64 -14Improve ping limiter error message
mediawiki/coremaster+121 -40Improve ping limiter error message
Customize query in gerrit

Related Objects

Event Timeline

Tgr created this task.Feb 14 2018, 1:57 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 14 2018, 1:57 AM
Tgr added a comment.Feb 14 2018, 1:58 AM

Probably related to T134953: Merge Throttler and ping limiter.

Harej awarded a token.Feb 14 2018, 1:59 AM
Tgr added a project: good first task.Feb 14 2018, 2:03 AM
Chicocvenancio added a subscriber: Chicocvenancio.Feb 14 2018, 2:12 AM
DovAlp added a subscriber: DovAlp.Apr 29 2018, 12:13 AM
This comment was removed by DovAlp.
BhargavInturi added a subscriber: BhargavInturi.Dec 14 2019, 4:51 PM
BhargavInturi claimed this task.Dec 25 2019, 2:28 PM
Aklapper added a comment.Jan 6 2020, 1:34 PM

@BhargavInturi: Hi and welcome! How is it going? Do you need any help with anything for this task?

BhargavInturi removed BhargavInturi as the assignee of this task.Jan 6 2020, 1:37 PM
vaibhavsingh added a subscriber: vaibhavsingh.Jan 7 2020, 7:38 PM
Swayamsrk added a subscriber: Swayamsrk.Jan 31 2020, 10:48 AM

Can I work on this issue?

Aklapper added a comment.Jan 31 2020, 4:02 PM

@Swayamsrk : Hi and welcome! Please see https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker#Communicate_that_you_work_on_a_task

Jdlrobson added a project: MediaWiki-Authentication-and-authorization.Jan 13 2021, 5:52 PM
Jdlrobson added a subscriber: Jdlrobson.

I'm making sure anything tagged with mediawiki-interface also has a more specific tag. Is this one appropriate?

Tgr added a comment.Jan 18 2021, 7:38 AM

I suppose you could argue that throttling is a kind of authorization. I don't think we have any component that would be a closer match, at least.

Diesel_kapasule added a subscriber: Diesel_kapasule.Mar 14 2022, 10:31 AM
This comment was removed by Diesel_kapasule.
gerritbot added a comment.Apr 20 2022, 9:59 AM

Change 784315 had a related patch set uploaded (by Diesel kapasule; author: Diesel kapasule):

[mediawiki/core@master] Improve ping limiter error message

https://gerrit.wikimedia.org/r/784315

gerritbot added a project: Patch-For-Review.Apr 20 2022, 9:59 AM
gerritbot added a comment.Apr 21 2022, 1:16 PM

Change 784315 abandoned by Diesel kapasule:

[mediawiki/core@master] Improve ping limiter error message

Reason:

https://gerrit.wikimedia.org/r/784315

Maintenance_bot removed a project: Patch-For-Review.Apr 21 2022, 1:30 PM
gerritbot added a comment.Apr 21 2022, 1:32 PM

Change 785150 had a related patch set uploaded (by Diesel kapasule; author: Diesel kapasule):

[mediawiki/core@master] Improve ping limiter error message

https://gerrit.wikimedia.org/r/785150

gerritbot added a project: Patch-For-Review.Apr 21 2022, 1:32 PM
Diesel_kapasule changed the task status from Open to In Progress.Apr 29 2022, 10:22 AM
Diesel_kapasule claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL