Description
Details
Related Objects
- Mentioned In
- rETHR2a152883113a: Allow attachBadge to be passed a non-image
rETHR69d9e77b06f2: Allow attachBadge to be passed a non-image
rETHR341cb9576cf6: Allow attachBadge to be passed a non-image
rETHR79026a5b4c95: Allow attachBadge to be passed a non-image
rETHR8d2b126649f1: Allow attachBadge to be passed a non-image
rETHRc99a936f2915: Only wait for thumb load for imgs
rETHRc46792c74a82: Don't attempt to attach badge to MMV canvas - Mentioned Here
- T183961: 1.31.0-wmf.22 deployment blockers
Event Timeline
Change 410455 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/3D@master] Don't attempt to attach badge to MMV canvas
The above patch fixes the issue by not attempting to draw the badge in MMV. One could perhaps rewrite this to work in future, but the most pressing issue is these 404 requests.
Change 410481 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/3D@master] Only wait for thumb load for imgs
Change 410491 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/3D@master] Allow attachBadge to be passed a non-image
Change 410481 abandoned by Matthias Mullie:
Only wait for thumb load for imgs
Reason:
See https://gerrit.wikimedia.org/r/#/c/410491/
Change 410491 merged by jenkins-bot:
[mediawiki/extensions/3D@master] Allow attachBadge to be passed a non-image
Change 410455 abandoned by Esanders:
Don't attempt to attach badge to MMV canvas
Reason:
https://gerrit.wikimedia.org/r/#/c/410491/ fixed the badge instead
Issue is still current; fix presumably got rolled back by the rollback of 1.31-wmf.22 (T183961)?
