Page MenuHomePhabricator

Changeprop should log the URL when it fails to connect
Open, Needs TriagePublic

Description

Here's an example logline where change-propagation times out, attempting to contact a local API point which I'm debugging. The URL it's contacting should be http://ores.local.wmftest.net:18880/v3/jade/wiki/create/123, but that's not recorded in the log message. It would be helpful if it were recorded.

{
    "description": "504: internal_http_error",
    "event_str": "{\"meta\":{\"topic\":\"change-prop.retry.mediawiki.revision-create\",\"schema_uri\":\"retry/1\",\"uri\":\"http://dev.wiki.local.wmftest.net:8080/wiki/Jade:Revision/2\",\"domain\":\"dev.wiki.local.wmftest.net\"},\"triggered_by\":\"req:00d72c75-30cd-41ef-9c7b-994eac4c90e0,mediawiki.revision-create:http://dev.wiki.local.wmftest.net:8080/wiki/Jade:Revision/2,change-prop.retry.mediawiki.revision-create:http://dev.wiki.local.wmftest.net:8080/wiki/Jade:Revision/2,change-prop.retry.mediawiki.revision-create:http://dev.wiki.local.wmftest.net:8080/wiki/Jade:Revision/2\",\"emitter_id\":\"change-prop#page_edit\",\"retries_left\":0,\"original_event\":{\"comment\":\"better\",\"database\":\"wiki\",\"meta\":{\"domain\":\"dev.wiki.local.wmftest.net\",\"dt\":\"2018-02-14T19:10:27+00:00\",\"id\":\"b769c322-11ba-11e8-b4c0-0800278dc04d\",\"request_id\":\"00d72c75-30cd-41ef-9c7b-994eac4c90e0\",\"schema_uri\":\"mediawiki/revision/create/2\",\"topic\":\"mediawiki.revision-create\",\"uri\":\"http://dev.wiki.local.wmftest.net:8080/wiki/Jade:Revision/2\"},\"page_id\":5,\"page_is_redirect\":false,\"page_namespace\":810,\"page_title\":\"Jade:Revision/2\",\"parsedcomment\":\"better\",\"performer\":{\"user_groups\":[\"*\"],\"user_is_bot\":false,\"user_text\":\"10.0.2.2\"},\"rev_content_changed\":true,\"rev_content_format\":\"JadeJudgment\",\"rev_content_model\":\"JadeJudgment\",\"rev_id\":12,\"rev_len\":373,\"rev_minor_edit\":false,\"rev_parent_id\":11,\"rev_sha1\":\"nua78v34plkqciretueisip8qes2qv6\",\"rev_timestamp\":\"2018-02-14T19:10:27Z\"}}",
    "hostname": "mediawikivagrant",
    "level": 40,
    "levelPath": "warn/page_edit",
    "message": "Retry count exceeded",
    "msg": "Retry count exceeded",
    "name": "changeprop",
    "page": "http://dev.wiki.local.wmftest.net:8080/wiki/Jade:Revision/2",
    "pid": 4447,
    "stack": "Error: ETIMEDOUT\n    at Timeout._onTimeout (/vagrant/srv/changeprop/node_modules/preq/index.js:22:25)\n    at ontimeout (timers.js:386:11)\n    at tryOnTimeout (timers.js:250:5)\n    at Timer.listOnTimeout (timers.js:214:5)",
    "status": 504,
    "time": "2018-02-14T19:17:45.241Z",
    "v": 0
}

Event Timeline

awight created this task.Feb 14 2018, 7:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 14 2018, 7:25 PM
awight updated the task description. (Show Details)Feb 14 2018, 7:25 PM
awight updated the task description. (Show Details)
awight removed a subscriber: awight.Mar 21 2019, 4:02 PM
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptMar 21 2019, 4:02 PM