Page MenuHomePhabricator

Failure in EventBus schema for mediawiki/revision/visibility-change
Open, Needs TriagePublic

Description

Suppression in a custom namespace threw this error in mw-vagrant:

Feb 14 19:34:24 mediawikivagrant eventlogging-service[2299]: 2018-02-14 19:34:24,558 [2299] (MainThread) Failed processing event: Failed validating <Event 0ff2fc72-11be-11e8-b4c0-0800278dc04d of schema (u'mediawiki/revision/visibility-change', 1)>. None is not of type 'string'
Feb 14 19:34:24 mediawikivagrant eventlogging-service[2299]: 2018-02-14 19:34:24,559 [2299] (MainThread) 0 out of 1 events were accepted.
Feb 14 19:34:24 mediawikivagrant eventlogging-service[2299]: 2018-02-14 19:34:24,560 [2299] (MainThread) 400 POST /v1/events (::1) 11.58ms

I can't find the offending message in Kafka, but it would have been similar to this earlier message in the same namespace,

{"comment": "new quality", "database": "wiki", "meta": {"domain": "dev.wiki.local.wmftest.net", "dt": "2018-02-13T19:30:07+00:00", "id": "4ca4cea3-10f4-11e8-9e46-0800278dc04d", "request_id": "852cff7f-12a5-48e9-a9f4-94c93e7381e1", "schema_uri": "mediawiki/revision/visibility-change/1", "topic": "mediawiki.revision-visibility-change", "uri": "http://dev.wiki.local.wmftest.net:8080/wiki/Jade:Revision/2"}, "page_id": 5, "page_is_redirect": false, "page_namespace": 810, "page_title": "Jade:Revision/2", "parsedcomment": "new quality", "performer": {"user_edit_count": 1, "user_groups": ["bureaucrat", "suppress", "sysop", "*", "user"], "user_id": 1, "user_is_bot": false, "user_registration_dt": "2018-02-07T14:57:14Z", "user_text": "Admin"}, "prior_state": {"visibility": {"comment": false, "text": true, "user": true}}, "rev_content_format": "JadeJudgment", "rev_content_model": "JadeJudgment", "rev_id": 7, "rev_len": 373, "rev_minor_edit": false, "rev_sha1": "nua78v34plkqciretueisip8qes2qv6", "rev_timestamp": "2018-02-13T18:52:59Z", "visibility": {"comment": true, "text": true, "user": false}}

Event Timeline

awight created this task.Feb 14 2018, 7:37 PM
Restricted Application added a project: Analytics. · View Herald TranscriptFeb 14 2018, 7:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@awight I've checked the message that you've provided and that one passes the validation.

The error message is rather cryptic, so I've created T188027 for us to make it more useful.

In the meantime, the EventBus service can store all the failed messages to a special log file if you specify
--error-output file://<path_to_a_file> as a parameter to it. In vagrant the parameters are stored under /vagrant/srv/eventlogging/config/eventlogging - so if you just modify that and restart the eventlogging-service-eventbus.service - that should give you the exact failing event next time something fails validation. With the event you've posted here I'm afraid I can't help you.

mobrovac renamed this task from Failure in eventlogging schema for mediawiki/revision/visibility-change to Failure in EventBus schema for mediawiki/revision/visibility-change.Feb 22 2018, 6:24 PM
fdans edited projects, added Analytics; removed Analytics-Kanban.Mar 22 2018, 4:51 PM
fdans moved this task from Incoming to Radar on the Analytics board.Mar 26 2018, 4:43 PM
awight removed a subscriber: awight.Thu, Mar 21, 4:02 PM
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptThu, Mar 21, 4:02 PM