Page MenuHomePhabricator
Create Task
Maniphest T187378

BadMethodCallException from line 66 of extensions/TwoColConflict/includes/TwoColConflictHooks.php: Call to a member function getId() on a non-object (null)
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error Message

BadMethodCallException from line 66 of extensions/TwoColConflict/includes/TwoColConflictHooks.php: Call to a member function getId() on a non-object (null)

Exception URI

/w/index.php?title=Template:Motd/2018-02-17_(mk)&action=submit

Stack Trace

#0 /srv/mediawiki/php-1.31.0-wmf.21/includes/Hooks.php(177): TwoColConflictHooks::onEditPageBeforeConflictDiff(EditPage, OutputPage)
#1 /srv/mediawiki/php-1.31.0-wmf.21/includes/Hooks.php(205): Hooks::callHook(string, array, array, NULL)
#2 /srv/mediawiki/php-1.31.0-wmf.21/includes/EditPage.php(3737): Hooks::run(string, array)
#3 /srv/mediawiki/php-1.31.0-wmf.21/includes/EditPage.php(2932): EditPage->showConflict()
#4 /srv/mediawiki/php-1.31.0-wmf.21/includes/EditPage.php(705): EditPage->showEditForm()
#5 /srv/mediawiki/php-1.31.0-wmf.21/includes/actions/EditAction.php(60): EditPage->edit()
#6 /srv/mediawiki/php-1.31.0-wmf.21/includes/actions/SubmitAction.php(38): EditAction->show()
#7 /srv/mediawiki/php-1.31.0-wmf.21/includes/MediaWiki.php(500): SubmitAction->show()
#8 /srv/mediawiki/php-1.31.0-wmf.21/includes/MediaWiki.php(294): MediaWiki->performAction(Article, Title)
#9 /srv/mediawiki/php-1.31.0-wmf.21/includes/MediaWiki.php(861): MediaWiki->performRequest()
#10 /srv/mediawiki/php-1.31.0-wmf.21/includes/MediaWiki.php(524): MediaWiki->main()
#11 /srv/mediawiki/php-1.31.0-wmf.21/index.php(42): MediaWiki->run()
#12 /srv/mediawiki/w/index.php(3): include(string)
#13 {main}

Notes

This is generating logspam which may block the train for wmf.21

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/TwoColConflictmaster+2 -1Handle EditPage::getBaseRevision returning null in Hooks
mediawiki/extensions/TwoColConflictwmf/1.31.0-wmf.21+2 -1Handle EditPage::getBaseRevision returning null in Hooks
mediawiki/coremaster+2 -2EditPage::getBaseRevision can return null. (fix phpdoc)
Customize query in gerrit

Related Objects

Event Timeline

mmodell created this task.Feb 14 2018, 8:52 PM
Restricted Application added a project: archived--TCB-Team. · View Herald TranscriptFeb 14 2018, 8:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
mmodell triaged this task as High priority.Feb 14 2018, 8:54 PM
mmodell added a parent task: T183960: 1.31.0-wmf.21 deployment blockers.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.Feb 14 2018, 9:04 PM

Line 66 is

					'baseRevisionId' => $editPage->getBaseRevision()->getId(),

Same issue as elsewhere?

mmodell updated the task description. (Show Details)Feb 14 2018, 9:07 PM
Lea_WMDE added a project: WMDE-QWERTY-Sprint-2018-02-06.Feb 15 2018, 8:53 AM
Lea_WMDE added subscribers: Andrew-WMDE, WMDE-Fisch, Addshore, Lea_WMDE.

@WMDE-Fisch @Andrew-WMDE @Addshore could you look at this?

Addshore claimed this task.Feb 15 2018, 9:58 AM
Restricted Application added a project: User-Addshore. · View Herald TranscriptFeb 15 2018, 9:58 AM
gerritbot added a subscriber: gerritbot.Feb 15 2018, 10:10 AM

Change 410787 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/core@master] EditPage::getBaseRevision can return null. (fix phpdoc)

https://gerrit.wikimedia.org/r/410787

gerritbot added a project: Patch-For-Review.Feb 15 2018, 10:10 AM

Change 410788 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/TwoColConflict@master] Handle EditPage::getBaseRevision returning null in Hooks

https://gerrit.wikimedia.org/r/410788

Addshore moved this task from Proposed to Review on the WMDE-QWERTY-Sprint-2018-02-06 board.Feb 15 2018, 10:12 AM
Addshore moved this task from Unsorted 💣 to Active 🚁 on the User-Addshore board.
Addshore mentioned this in rESCCc7ed09f52a10: Handle EditPage::getBaseRevision returning null in Hooks.Feb 15 2018, 10:15 AM
gerritbot added a comment.Feb 15 2018, 11:03 AM

Change 410787 merged by jenkins-bot:
[mediawiki/core@master] EditPage::getBaseRevision can return null. (fix phpdoc)

https://gerrit.wikimedia.org/r/410787

gerritbot added a comment.Feb 15 2018, 11:28 AM

Change 410809 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/TwoColConflict@wmf/1.31.0-wmf.21] Handle EditPage::getBaseRevision returning null in Hooks

https://gerrit.wikimedia.org/r/410809

Addshore mentioned this in rESCC0e82794a1528: Handle EditPage::getBaseRevision returning null in Hooks.Feb 15 2018, 11:29 AM
Addshore mentioned this in rESCC074ae101160d: Handle EditPage::getBaseRevision returning null in Hooks.
Addshore mentioned this in rESCCcdd9d7423438: Handle EditPage::getBaseRevision returning null in Hooks.Feb 15 2018, 11:31 AM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)).Feb 15 2018, 12:01 PM
gerritbot added a comment.Feb 15 2018, 8:05 PM

Change 410809 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@wmf/1.31.0-wmf.21] Handle EditPage::getBaseRevision returning null in Hooks

https://gerrit.wikimedia.org/r/410809

mmodell removed a parent task: T183960: 1.31.0-wmf.21 deployment blockers.Feb 15 2018, 8:24 PM
gerritbot added a comment.Feb 15 2018, 8:27 PM

Change 410788 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Handle EditPage::getBaseRevision returning null in Hooks

https://gerrit.wikimedia.org/r/410788

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)); removed MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)).Feb 15 2018, 9:00 PM
Addshore closed this task as Resolved.Feb 16 2018, 10:38 AM
mmodell awarded a token.Feb 17 2018, 7:55 AM
Tobi_WMDE_SW moved this task from Review to Done on the WMDE-QWERTY-Sprint-2018-02-06 board.Feb 20 2018, 1:34 PM
Tobi_WMDE_SW added a project: WMDE-TechWish.Feb 20 2018, 4:23 PM
Tobi_WMDE_SW moved this task from Proposed to Demoed on the WMDE-TechWish board.
Addshore moved this task from Active 🚁 to Closing ✔️ on the User-Addshore board.Feb 23 2018, 12:29 PM
mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptAug 28 2019, 11:09 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 28 2019, 11:36 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL