Verify latest version of flamegraph.pl locally and submit bug report if needed
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Krinkle
	Feb 14 2018, 10:51 PM

Description

There haven't been many changes, but since we occasionally get a minor error that may've been fixed upstream, let's try updating first.

Pull down some logs from https://performance.wikimedia.org/xenon/logs/.
Convert them all to SVGs with current version we have in puppet, and see if we can reproduce the error.
Convert them all to SVGs with the latest version from https://github.com/brendangregg/FlameGraph/, and verify that there are no new errors, and that the output looks good.
Submit a bug report with repro case to https://github.com/brendangregg/FlameGraph/

Related Objects
Search...

Status	Assigned	Task
Open	None	T294906 Puppet Improvements 2021/2022
Open	jbond	T265138 Work required to prepare for puppet 6
Open	None	T273673 replace all puppet crons with systemd timers
Open	None	T132324 Tracking and Reducing cron-spam to root@
Resolved	• Gilles	T169249 /usr/local/bin/xenon-generate-svgs and flamegraph.pl cronspam
Resolved	• Gilles	T187397 Verify latest version of flamegraph.pl locally and submit bug report if needed

Event Timeline

Krinkle triaged this task as Medium priority.Feb 14 2018, 10:51 PM

Krinkle created this task.

• Imarlier moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.Feb 26 2018, 9:37 PM

• Gilles claimed this task.Apr 13 2018, 10:56 AM

Managed to reproduce the issue locally:

Generating /srv/xenon/svgs/daily/2018-02-13.all.reversed.svgz...
Use of uninitialized value $stack in pattern match (m//) at /usr/local/bin/flamegraph.pl line 499, <> line 100553.
Use of uninitialized value $stack in split at /usr/local/bin/flamegraph.pl line 504, <> line 100553.
Use of uninitialized value $samples in concatenation (.) or string at /usr/local/bin/flamegraph.pl line 504, <> line 100553.
Ignored 1 lines with invalid format

The latest version of flamegraph.pl doesn't fix the issue

• Gilles renamed this task from Update flamegraph.pl to latest upstream version to Verify latest version of flamegraph.pl locally and submit bug report if needed.Apr 13 2018, 2:03 PM

• Gilles updated the task description. (Show Details)

I think I've found the cause, it's not flamegraph.pl

I'll continue the conversation on the parent task.

Verify latest version of flamegraph.pl locally and submit bug report if neededClosed, ResolvedPublicActions

Description

Related ObjectsSearch...

Event Timeline

Verify latest version of flamegraph.pl locally and submit bug report if needed
Closed, ResolvedPublic
Actions

Related Objects
Search...