Page MenuHomePhabricator

Muting feature UI appears broken with GlobalPrefs
Closed, ResolvedPublic2 Estimated Story Points

Description

How it looks in usual Preferences:

Screen Shot 2018-02-14 at 4.36.50 PM.png (332×1 px, 61 KB)

How it looks in GlobalPreferences:

Screen Shot 2018-02-14 at 4.37.08 PM.png (230×1 px, 44 KB)

Also observed in Notifications tab:

Screen Shot 2018-02-15 at 2.19.08 PM.png (224×1 px, 27 KB)

I see a flash of an expanded textbox just before this.
As seen in Safari and Chrome.

Event Timeline

This seems to be a result of trying to mimic the table layout of Special:Preferences by setting display:table-cell on the form input wrappers. Easy enough to fix, with div.mw-htmlform-field-HTMLUsersMultiselectField div.mw-input {display:inline} but when I do so I'm getting a weird scroll jump to the top and Firefox complains:

This site appears to use a scroll-linked positioning effect. This may not work well with asynchronous panning; see https://developer.mozilla.org/docs/Mozilla/Performance/ScrollLinkedEffects for further details and to join the discussion on related tools and features!

@dbarratt does that widget do anything with scrolling?

@dbarratt does that widget do anything with scrolling?

Uhh... not that I know of, we used a widget that was already in MediaWiki (I can't remember what it was being used for).

Change 413074 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/extensions/GlobalPreferences@master] Handle OOUI widgets

https://gerrit.wikimedia.org/r/413074

Samwilson edited projects, added Community-Tech-Sprint; removed Community-Tech.
Samwilson set the point value for this task to 2.

No, it seems the scroll error was unrelated.

The above patch fixes the display, and also addresses the betafeatures-enabledness part of T187490#3977419 (i.e. fixes for OOUI in general).

Change 413074 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@master] Handle OOUI widgets

https://gerrit.wikimedia.org/r/413074