Figure out Maki's Mapnik requirements
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Pnorman
	Feb 15 2018, 6:06 PM

Description

We forced an older version of some maki-related dependencies in https://phabricator.wikimedia.org/rGMKT0b0c68d4ee564c61d27cc994450b8a98fc149d12

This is because new versions were pulling in Mapnik, causing problems with both node-mapnik 3.5 and 3.6 being installed. The 3.5 was being installed as part of Kartotherian and being built from source (see node-mapnik + glibc + semver violations) and 3.6 was not desired.

The idea of needing Mapnik to install an icon library is, put simply, insane. Rather than being stuck on an old version forever, we need to figure out what is going on.

The fix will probably involve some kind of PR to some maki-related repos owned by Mapbox.

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T321959 Tech Wishes - Maps service infrastructure deprecations
Invalid	None	T321789 Upgrade maps servers to node >= 14
Duplicate	None	T210815 Upgrade kartotherian to latest upstream node-mapnik
Resolved	Jgiannelos	T213077 Migrate Kartotherian to node-mapnik >v4.2.1 to support libmapnik >3.1.x
Resolved	MSantos	T209990 Test Kartotherian/Tilerator with node 10
Invalid	None	T195316 unmet peer dependency warning on kartotherian and tilerator builds
		Restricted Task
		Restricted Task
Resolved	MSantos	T188674 Upgrade node-mapnik to 3.7.x
Resolved	None	T187481 Figure out Maki's Mapnik requirements

Event Timeline

Pnorman created this task.Feb 15 2018, 6:06 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 15 2018, 6:06 PM

This is still an issue - we need to figure out what's happening, but it's not an immediate priority. This is independent of needing to upgrade Mapnik

• Mholloway moved this task from Backlog to To-do on the Maps-Sprint board.Jul 3 2018, 4:57 PM

It's coming in through @mapbox/makizushi. makizushi doesn't actually appear to use mapnik (though its dependency @mapbox/blend does). I'm guessing the intention is to enforce mapnik version consistency with other components it's intended to work with, but strictly speaking it's an unnecessary direct dependency.

That said, the problem of needing to maintain mapnik version consistency among the various dependencies is not unique to maki. I'm not sure anything in particular needs to be done here. We could try and persuade mapbox to remove the explicit node-mapnik dependency from makizushi, but it wouldn't resolve the general problem of potential mapnik version disagreements.

• Mholloway added a project: Maps (Kartotherian).Jul 24 2018, 5:34 PM

• Mholloway moved this task from To-do to Backlog on the Maps-Sprint board.Jul 24 2018, 8:47 PM

LGoto added a project: Product-Infrastructure-Team-Backlog-Deprecated.Jul 25 2018, 4:20 PM

• Jhernandez moved this task from Needs triage to Backlog on the Product-Infrastructure-Team-Backlog-Deprecated board.Aug 1 2018, 3:35 PM

MSantos added a parent task: T188674: Upgrade node-mapnik to 3.7.x.Aug 16 2018, 6:33 PM

Assinging as a subtask of T188674: Upgrade node-mapnik to 3.7.x and marking this as solved. @kartotherian/maki now has the latest version of @mapbox/makizushi