Page MenuHomePhabricator

Phan fails when vendor is part of folder list since --no-dev is removed from composer update
Closed, ResolvedPublic

Description

https://gerrit.wikimedia.org/r/#/c/410372/ removed -no-dev from composer which results in the code for dev dependencies like codesniffer or php linter.

Both are not pass on phan, so this broke the CI tests there.

The failing output:
https://integration.wikimedia.org/ci/job/mwext-php70-phan-docker/3165/console

The extensions:
https://codesearch.wmflabs.org/search/?q=%5C.%2Fvendor%5B'%22'%5D&i=nope&files=.*%5C.php%24&repos=

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 15 2018, 7:38 PM
Legoktm claimed this task.Feb 15 2018, 8:02 PM

I don't understand why this only failed for CiteThisPage and not every other phan extension.

Oh, I see. For example Cite only lints the includes/ directory, so vendor/ won't get picked up. CiteThisPage lints ., so it includes vendor/. Patch incoming.

Change 411075 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/CiteThisPage@master] phan: Only check includes/ directory

https://gerrit.wikimedia.org/r/411075

Change 411075 merged by jenkins-bot:
[mediawiki/extensions/CiteThisPage@master] phan: Only check includes/ directory

https://gerrit.wikimedia.org/r/411075

Umherirrender closed this task as Resolved.Feb 24 2018, 9:56 PM

All extensions now using phan-config and does not include a '.'