Page MenuHomePhabricator
Create Task
Maniphest T187510

MassMessage preview is returning an Internal 500 error
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

MassMessage requires a preview step before sending.

Preview returns the attached screenshot. with the error message copied here:

Request from 2601:243:402:6830:61b0:b08b:f43d:c32c via cp2019 cp2019, Varnish XID 177303312
Error: 500, Internal Server Error at Thu, 15 Feb 2018 22:20:49 GMT

MassMessage is unable to complete the sending process without completing preview, so this breaks the tool.

Screen Shot 2018-02-15 at 4.18.04 PM.png (585×1 px, 67 KB)

Details

SubjectRepoBranchLines +/-
Fix use statement for MediaWikiServicesmediawiki/extensions/MassMessagewmf/1.31.0-wmf.21+1 -1
Fix use statement for MediaWikiServicesmediawiki/extensions/MassMessagemaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Keegan created this task.Feb 15 2018, 10:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 15 2018, 10:26 PM
MarcoAurelio subscribed.Feb 15 2018, 10:27 PM

Hmm. This reminds me of T186098 but in a different page.

Paladox subscribed.Feb 15 2018, 10:28 PM

UBN?

MarcoAurelio added a comment.Feb 15 2018, 10:29 PM

Let me test.

Quiddity subscribed.Feb 15 2018, 10:29 PM
MarcoAurelio triaged this task as Unbreak Now! priority.Feb 15 2018, 10:31 PM
MarcoAurelio added subscribers: Noella94, Legoktm.

Break confirmed on preview:

Request from [redacted] via cp3030 cp3030, Varnish XID 485866892
Error: 500, Internal Server Error at Thu, 15 Feb 2018 22:30:22 GMT

@Legoktm @Noella94 Please investigate your recent contributions on the extension :)

Restricted Application added subscribers: Liuxinyu970226, Jay8g, TerraCodes. · View Herald TranscriptFeb 15 2018, 10:31 PM
MarcoAurelio added a project: Wikimedia-production-error.Feb 15 2018, 10:36 PM
MarcoAurelio moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.
Legoktm added a comment.Feb 15 2018, 10:38 PM

PHP Fatal Error: Class undefined: MediaWiki\MassMessage\MediaWikiServices

Legoktm added a comment.Feb 15 2018, 10:41 PM

https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/MassMessage/+/wmf/1.31.0-wmf.21/includes/MassMessage.php

Maybe the use statement doesn't work if its above the namespace block?

gerritbot subscribed.Feb 15 2018, 10:43 PM

Change 411165 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/MassMessage@master] Fix use statement for MediaWikiServices

https://gerrit.wikimedia.org/r/411165

gerritbot added a project: Patch-For-Review.Feb 15 2018, 10:43 PM
gerritbot added a comment.Feb 15 2018, 10:47 PM

Change 411167 had a related patch set uploaded (by Chad; owner: Legoktm):
[mediawiki/extensions/MassMessage@wmf/1.31.0-wmf.21] Fix use statement for MediaWikiServices

https://gerrit.wikimedia.org/r/411167

gerritbot added a comment.Feb 15 2018, 10:48 PM

Change 411165 merged by jenkins-bot:
[mediawiki/extensions/MassMessage@master] Fix use statement for MediaWikiServices

https://gerrit.wikimedia.org/r/411165

gerritbot added a comment.Feb 15 2018, 10:52 PM

Change 411167 merged by jenkins-bot:
[mediawiki/extensions/MassMessage@wmf/1.31.0-wmf.21] Fix use statement for MediaWikiServices

https://gerrit.wikimedia.org/r/411167

Stashbot subscribed.Feb 15 2018, 10:54 PM

Mentioned in SAL (#wikimedia-operations) [2018-02-15T22:54:46Z] <demon@tin> Synchronized php-1.31.0-wmf.21/extensions/MassMessage/includes/MassMessage.php: fix use statement, T187510 (duration: 00m 57s)

Quiddity closed this task as Resolved.Feb 15 2018, 10:58 PM
Quiddity assigned this task to Legoktm.
MarcoAurelio removed a project: Patch-For-Review.Feb 15 2018, 10:58 PM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)).Feb 15 2018, 11:00 PM
Liuxinyu970226 unsubscribed.Feb 17 2018, 3:57 AM
Krinkle moved this task from Dec2019/1.35.wmf.10+ to Resolved on the Wikimedia-production-error board.May 29 2019, 4:00 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL