Page MenuHomePhabricator

Support non-Gregorian calendars in range checkers
Open, Needs TriagePublic


RangeCheckerHelper (used by RangeChecker and DiffWithinRangeChecker, “range” and “difference within range” constraint types) uses TimeValueCalculator to operate on dates, which throws away the calendar of a TimeValue and assumes that its time stamp is in the Gregorian calendar. We need to fix that at some point. Wikibase already seems to have some provision to convert Julian dates to Gregorian ones for the RDF export, so I assume we can reuse that.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 16 2018, 11:16 AM

The conversion for RDF happens in JulianDateTimeValueCleaner – unfortunately, it returns an xsd:dateTime string, which isn’t immediately reusable as a TimeValue timestamp… I hope it won’t be too hard to adapt, though.