Maniphest T187551

3D viewer not initialised after visual editor edit
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Esanders
	Feb 16 2018, 2:17 PM

Tags

Referenced Files

None

Subscribers

Description

Only runs on page load, should run on wikipage.content hook instead.

Example: https://commons.wikimedia.org/wiki/User:ESanders_(WMF)/3D?veaction=edit

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Run 3D init on wikipage.content hook	mediawiki/extensions/3D	master	+8 -1

Customize query in gerrit

Related Objects

Mentioned In: rETHR85d934328a6f: Run 3D init on wikipage.content hook

Event Timeline

Esanders created this task.Feb 16 2018, 2:17 PM

Restricted Application added a project: Multimedia. · View Herald TranscriptFeb 16 2018, 2:17 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 411242 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/3D@master] Run 3D init on wikipage.content hook

https://gerrit.wikimedia.org/r/411242

gerritbot added a project: Patch-For-Review.Feb 16 2018, 2:17 PM

Esanders moved this task from To Triage to Current work on the VisualEditor board.Feb 16 2018, 2:18 PM

Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.

Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.

Esanders mentioned this in rETHR85d934328a6f: Run 3D init on wikipage.content hook.Feb 16 2018, 2:18 PM

Jdforrester-WMF assigned this task to Esanders.Feb 16 2018, 5:09 PM

• Ramsey-WMF moved this task from Untriaged to Tracking on the Multimedia board.Feb 16 2018, 8:22 PM

• Ramsey-WMF awarded a token.Feb 16 2018, 8:52 PM

Change 411242 merged by jenkins-bot:
[mediawiki/extensions/3D@master] Run 3D init on wikipage.content hook

https://gerrit.wikimedia.org/r/411242

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)).Feb 19 2018, 2:00 PM

• Deskana triaged this task as Medium priority.Feb 19 2018, 3:26 PM

• Deskana set the point value for this task to 1.

Jdforrester-WMF moved this task from Code review to Product owner review on the VisualEditor (Current work) board.Feb 20 2018, 6:41 PM

Jdforrester-WMF removed a project: Patch-For-Review.Feb 20 2018, 6:58 PM

Esanders updated the task description. (Show Details)Feb 21 2018, 12:56 PM

• Deskana closed this task as Resolved.Feb 26 2018, 4:08 PM