Use a better method for detecting STL files on the page
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Feb 16 2018, 3:39 PM

Description

Currently we look for img[src$=stl.png]. This could be broken by uploading a file called 2d.airport.diagram.stl.png, which leads to weird behaviour.

It would be better if the parser added an appropriate class to 3D thumbnails instead. One could then add the 3D badge using a CSS-only solution.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/3D	master	+52 -12	Fix 3D thumbnail HTML in PHP

Customize query in gerrit

Related Objects

Mentioned In: rETHR33b179cb0885: Fix 3D thumbnail HTML in PHP
rETHR9e3e401e42cf: Add the 3D badge to thumbnail HTML in PHP
rETHR9bc90049431e: Fix 3D thumbnail HTML in PHP
T204621: Reduce footprint of ext.3d on page initialisation
Mentioned Here: T204621: Reduce footprint of ext.3d on page initialisation
T60478: Improve interface for MediaHandlers to add JavaScript

Event Timeline

Esanders created this task.Feb 16 2018, 3:39 PM

Restricted Application added a project: Multimedia. · View Herald TranscriptFeb 16 2018, 3:39 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• Ramsey-WMF assigned this task to matthiasmullie.Feb 16 2018, 8:20 PM

• Ramsey-WMF triaged this task as Medium priority.Feb 16 2018, 9:07 PM

• Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.

@brion Are you saying that's a blocker to this task?

See also T204621 for another reason why this is important.

Not a blocker, but it'd be nice to treat various media types consistently in that respect. Ought to be able to add a custom class on the <img> in some reasonable way already, though...

@Esanders worst case, currently should be possible to override the ThreeDHandler's doTransform method to return a custom ThumbnailImage subclass, which can add a class by sniping into the toHtml() method and appending to the img-class entry in options.

Sounds icky but I think it'll work. :D

Change 461403 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/3D@master] Fix 3D thumbnail HTML in PHP

https://gerrit.wikimedia.org/r/461403

gerritbot added a project: Patch-For-Review.Sep 19 2018, 1:43 PM

Esanders mentioned this in rETHR9bc90049431e: Fix 3D thumbnail HTML in PHP.Sep 19 2018, 1:48 PM

Jdforrester-WMF mentioned this in rETHR9e3e401e42cf: Add the 3D badge to thumbnail HTML in PHP.Sep 19 2018, 3:55 PM

Esanders mentioned this in rETHR33b179cb0885: Fix 3D thumbnail HTML in PHP.Sep 19 2018, 3:55 PM

Jdforrester-WMF closed this task as Resolved.Sep 19 2018, 4:27 PM

Jdforrester-WMF reassigned this task from matthiasmullie to Esanders.

Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Performance Issue; removed Patch-For-Review.

Jdforrester-WMF added a subscriber: matthiasmullie.

Change 461403 merged by jenkins-bot:
[mediawiki/extensions/3D@master] Fix 3D thumbnail HTML in PHP