Page MenuHomePhabricator

After the spam blacklist blocks an edit, show the edit form akin to edit conflicts
Closed, DuplicatePublic

Description

Author: leety

Description:
Currently when a user attempts to make a change which includes a blacklisted website they receive a "Spam filter notice" which tells them why their change was blocked but doesn't show the source of their attempt change.

With certain web browsers (particular I.E.), this means the entire attempted change is lost as using the content disappears when one uses the back button. Technically the content must still be somewhere in memory since refreshing results in another submission attempt but recovering it is obviously out of the realms of most users. If the edit was part of a large attempted change this is going to be rather annoying to the person who attempted to make the change, who may not have been aware of the site being black-listed and may not have been trying to do any harm.

To prevent this, I propose that when a change is blocked, the software should show the source of the attempted save as happens when the database is locked for example.

Cheers


Version: unspecified
Severity: enhancement

Details

Reference
bz16757

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:28 PM
bzimport added a project: SpamBlacklist.
bzimport set Reference to bz16757.
bzimport added a subscriber: Unknown Object (MLST).

mike.lifeguard+bugs wrote:

Probably the edit form would work better - the user can modify the page text directly there & retry the save.

alejrb wrote:

Yep, I see no reason why the edit box shouldn't simply be shown again, in a similar sort of way to edit conflicts.

mike.lifeguard+bugs wrote:

(In reply to comment #2)

Yep, I see no reason why the edit box shouldn't simply be shown again, in a
similar sort of way to edit conflicts.

Changed the summary then.

Shows edit form on spam error.

Attached:

mike.lifeguard+bugs wrote:

(In reply to comment #5)

keyword: +patch

+need-review

mike.lifeguard+bugs wrote:

*** Bug 17903 has been marked as a duplicate of this bug. ***

  • Bug 17683 has been marked as a duplicate of this bug. ***

herd wrote:

*** This bug has been marked as a duplicate of bug 9416 ***