Move from non-developed, deprecated Mapbox.js to Leaflet
Open, LowPublic
Actions

Assigned To

None

Authored By

	Pnorman
	Feb 16 2018, 8:53 PM

Description

Right now Kartographer embeds Mapbox.js, which is Mapbox's version of Leaflet. There's nothing which can't be done with base Leaflet.

We should switch to base Leaflet, which will help maintenance by having us use a more standard library that more people are familiar with. It would also make it easier to keep up to date and get bugfixes from Leaflet.

This has been discussed a fair amount informally and is considered desirable.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	[WIP] Move from Mapbox.js to Leaflet	mediawiki/extensions/Kartographer	master	+42 K -19 K

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T187582 Move from non-developed, deprecated Mapbox.js to Leaflet
		Open		None	T158924 Convert LayerSelection control to OOUI

Event Timeline

Pnorman created this task.Feb 16 2018, 8:53 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 16 2018, 8:53 PM

TheDJ added a project: Maps (Kartographer).Mar 30 2018, 9:45 AM

TheDJ subscribed.

Abbe98 awarded a token.Apr 27 2018, 12:51 PM

Abbe98 added a project: User-Abbe98.May 13 2018, 11:35 AM

Abbe98 moved this task from Inbox to Watching on the User-Abbe98 board.May 13 2018, 11:37 AM

Do we know why originally the choice for mapbox.js was made?

I think the initial idea was to use client-side rendering, and mapbox offers a better path for that.

This is still a good idea and wouldn't result in any changes visible to the user.

• Mholloway moved this task from Backlog to To-do on the Maps-Sprint board.Jul 3 2018, 4:57 PM

• Mholloway removed a project: Maps-Sprint.Jul 3 2018, 6:34 PM

Change 451788 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/extensions/Kartographer@master] [WIP] Move from Mapbox.js to Leaflet

https://gerrit.wikimedia.org/r/451788

gerritbot added a project: Patch-For-Review.Aug 9 2018, 9:34 PM

MSantos subscribed.Aug 18 2018, 12:26 AM

MSantos moved this task from Unsorted to General on the Maps (Kartographer) board.Sep 25 2018, 3:38 PM

Mapbox.js is now considered legacy btw:
Mapbox.js is no longer in active development. To learn more about our newer mapping tools see Mapbox GL JS.

Aklapper renamed this task from Move from Mapbox.js to Leaflet to Move from non-developed, deprecated Mapbox.js to Leaflet.Feb 26 2020, 5:30 PM

I think I can actually wrap this up fairly easily soon. Finally had the time to develop a better understanding on the differences between mapbox.js and leaflet.js and know where and how to tackle them I think. want to see if i can also convert it to packageFiles RL structure.

Abbe98 mentioned this in T208713: Add button to move map to current location.Mar 2 2020, 7:40 AM

Seems we don't have a good layer icon in oo-ui, which we sort of need for the conversion...

Volker_E added a project: Design.May 18 2021, 12:29 AM

Volker_E subscribed.

This comment was removed by Volker_E.

Pppery edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Apr 1 2023, 8:10 PM

Pnorman unsubscribed.Oct 19 2023, 7:18 PM