Visual diff shows different result for comparable change (inserting one word)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Feb 16 2018, 11:00 PM

Description

In https://en.wikipedia.org/w/index.php?title=Star-Spangled_Banner_(flag)&curid=7246021&diff=826054878&oldid=812171510&diffmode=visual the word 'the' is inserted in two paragraphs, but in the second it is show as <del>at</del><ins>at the</ins>, whereas in the first it is just <ins>the</ins>.

Update: This is a smaller (minimal?) test case:

foo quux at bar
->
foo, quux at the bar

Details

	Subject	Repo	Branch	Lines +/-
	Update VE core submodule to master (a2dbc868a)	mediawiki/extensions/VisualEditor	master	+1 -1
	Update diff-match-patch and implement indexOf/lastIndexOf	VisualEditor/VisualEditor	master	+96 -22

Customize query in gerrit

Related Objects

Mentioned In: T197928: Visual diff shows non-minimal diff
Mentioned Here: rGVEDa2dbc868ae0f: Localisation updates from https://translatewiki.net.

Event Timeline

Esanders created this task.Feb 16 2018, 11:00 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 16 2018, 11:00 PM

Actually in the second paragraph, there is a comma inserted as well.

Esanders triaged this task as Low priority.Feb 16 2018, 11:01 PM

• Deskana moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.Feb 20 2018, 7:51 PM

Tchanders mentioned this in T197928: Visual diff shows non-minimal diff.Jul 18 2018, 1:46 PM

• marcella moved this task from TR6: Visual diffs to Bug Fixes on the VisualEditor board.Nov 13 2018, 6:50 PM

• marcella moved this task from Bug Fixes to Freezer on the VisualEditor board.Dec 13 2018, 4:51 PM

Esanders updated the task description. (Show Details)Sep 3 2020, 9:40 PM

Change 624720 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Update diff-match-patch and implement indexOf/lastIndexOf

https://gerrit.wikimedia.org/r/624720

gerritbot added a project: Patch-For-Review.Sep 4 2020, 2:52 PM

Change 624720 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Update diff-match-patch and implement indexOf/lastIndexOf

https://gerrit.wikimedia.org/r/624720

Maintenance_bot removed a project: Patch-For-Review.Sep 6 2020, 2:10 PM

Change 625769 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a2dbc868a)

https://gerrit.wikimedia.org/r/625769

gerritbot added a project: Patch-For-Review.Sep 8 2020, 2:27 AM

Change 625769 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a2dbc868a)

https://gerrit.wikimedia.org/r/625769

Maintenance_bot removed a project: Patch-For-Review.Sep 8 2020, 7:10 AM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.9; 2020-09-15).Sep 8 2020, 8:00 AM

matmarex added a project: Editing-team (Kanban Board).Sep 8 2020, 2:17 PM

matmarex moved this task from Incoming to QA on the Editing-team (Kanban Board) board.

matmarex subscribed.

matmarex added a project: Editing QA.Sep 16 2020, 5:19 PM

The diff https://en.wikipedia.org/w/index.php?title=Star-Spangled_Banner_(flag)&curid=7246021&diff=826054878&oldid=812171510&diffmode=visual now looks fine:

• ppelberg closed this task as Resolved.Sep 21 2020, 1:13 AM

• ppelberg claimed this task.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 21 2020, 1:13 AM

	F32353849: image.png
	Sep 17 2020, 6:43 PM

	F32243988: image.png
	Sep 3 2020, 9:40 PM

Visual diff shows different result for comparable change (inserting one word)Closed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Visual diff shows different result for comparable change (inserting one word)
Closed, ResolvedPublic
Actions