Page MenuHomePhabricator
Create Task
Maniphest T187687

Floated image in visual diffs on history page overlapping content
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

In https://de.wikipedia.org/w/index.php?title=Wikipedia:Technik/Werkstatt&type=revision&diff=174179377&oldid=174177794&diffmode=visual, the added image floats into the content. There should be a clear: both; somewhere to prevent this.
Note that (as far as I can see) this only happens when floating content is added to the very last section, as otherwise the indicator that the following content is omitted in the diff will do the clearing.

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (b615c2e21)mediawiki/extensions/VisualEditormaster+1 -1
Upstream diffElement clearfixVisualEditor/VisualEditormaster+6 -0
Add clearfix to diff page's visual diff elementmediawiki/extensions/VisualEditormaster+6 -0
Customize query in gerrit

Related Objects

Event Timeline

Schnark created this task.Feb 19 2018, 9:30 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptFeb 19 2018, 9:30 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Esanders merged a task: T187726: Historical Visual diff annotation column overlaps other content in certain diffs.Feb 20 2018, 2:50 PM
Esanders added a subscriber: TheDJ.
Esanders subscribed.
This comment was removed by Esanders.
Esanders renamed this task from Clear floats in visual diff to Visual diffs on history page overlapping content.Feb 20 2018, 2:51 PM
Esanders renamed this task from Visual diffs on history page overlapping content to Floated image in visual diffs on history page overlapping content.Feb 20 2018, 3:03 PM
gerritbot subscribed.Feb 20 2018, 3:05 PM

Change 412926 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Add clearfix to diff page's visual diff element

https://gerrit.wikimedia.org/r/412926

gerritbot added a project: Patch-For-Review.Feb 20 2018, 3:05 PM
Esanders claimed this task.Feb 20 2018, 3:07 PM
Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.
Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.
gerritbot added a comment.Feb 20 2018, 4:52 PM

Change 412926 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Add clearfix to diff page's visual diff element

https://gerrit.wikimedia.org/r/412926

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)).Feb 20 2018, 5:00 PM
Jdforrester-WMF moved this task from Code review to Product owner review on the VisualEditor (Current work) board.Feb 20 2018, 6:39 PM
Jdforrester-WMF removed a project: Patch-For-Review.Feb 20 2018, 6:57 PM
• Deskana closed this task as Resolved.Feb 22 2018, 12:10 PM
• Deskana set the point value for this task to 1.
gerritbot added a comment.Dec 2 2020, 7:20 PM

Change 644899 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Upstream diffElement clearfix

https://gerrit.wikimedia.org/r/644899

gerritbot added a project: Patch-For-Review.Dec 2 2020, 7:20 PM
gerritbot added a comment.Dec 2 2020, 9:12 PM

Change 644899 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Upstream diffElement clearfix

https://gerrit.wikimedia.org/r/644899

gerritbot added a comment.Dec 2 2020, 9:21 PM

Change 644925 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b615c2e21)

https://gerrit.wikimedia.org/r/644925

gerritbot added a comment.Dec 2 2020, 9:49 PM

Change 644925 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b615c2e21)

https://gerrit.wikimedia.org/r/644925

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.21; 2020-12-08).Dec 2 2020, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 2 2020, 10:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL