Page MenuHomePhabricator
Create Task
Maniphest T187694

Incorrect cursor position on pages with wrapped tabs (2017WTE + SyntaxHighlighting)
Closed, ResolvedPublic
Actions

Description

For example: https://meta.wikimedia.org/wiki/Reports?veaction=editsource

Details

SubjectRepoBranchLines +/-
VE: Match whitespace rendering of ve.ce.TextNodemediawiki/extensions/CodeMirrormaster+37 -4
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Feb 19 2018, 10:03 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 19 2018, 10:03 AM
Esanders renamed this task from Incorrect cursor position on pages with start of line tabs (2017WTE + SyntaxHighlighting) to Incorrect cursor position on pages with wrapped tabs (2017WTE + SyntaxHighlighting).Feb 19 2018, 10:04 AM
Esanders mentioned this in T181816: Incorrect cursor position in 2017 wikitext editor with syntaxhighlighting.
• Elitre subscribed.Feb 19 2018, 10:05 AM
Esanders added a comment.Feb 19 2018, 10:10 AM

CodeMirror renders tabs as single spaces using tabSize: 1, whereas VE renders them as ➞ in ve.ce.TextNode.

gerritbot subscribed.Feb 19 2018, 10:44 AM

Change 412666 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/CodeMirror@master] VE: Match whitespace rendering of ve.ce.TextNode

https://gerrit.wikimedia.org/r/412666

gerritbot added a project: Patch-For-Review.Feb 19 2018, 10:44 AM
Esanders claimed this task.Feb 19 2018, 11:25 AM
Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.
Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.
• Elitre awarded a token.Feb 19 2018, 11:37 AM
Kaartic subscribed.Feb 22 2018, 6:00 PM
Jdforrester-WMF moved this task from Code review to Product owner review on the VisualEditor (Current work) board.Feb 25 2018, 10:39 PM
Jdforrester-WMF removed a project: Patch-For-Review.
gerritbot added a comment.Feb 25 2018, 10:40 PM

Change 412666 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] VE: Match whitespace rendering of ve.ce.TextNode

https://gerrit.wikimedia.org/r/412666

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)).Feb 25 2018, 11:00 PM
• Deskana closed this task as Resolved.Mar 8 2018, 10:32 AM
• Deskana triaged this task as Medium priority.
matmarex mentioned this in T153434: Consider using colour/etc. to denote that tabs displayed as arrows / newlines as returns are not the raw Unicode character.Nov 24 2019, 10:16 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL