herd wrote:

Another oddity: With optional file renaming on, you can rename a file from "._jpg" to ".jpg" but you cannot rename it back, so whatever checks that works. ^_^

Should there not be one specific centralized function that detects extension (and overall filename) validity? Or consistency in the way it is used, at least?

Offhand it looks like the problem is that on upload it's doing the extension validity check on the name *before* normalizing spaces to "_", and that check is doing a trim() on the extension after separating it from the ".".

So:

1. The "_" normalization should be done as a first step.

2. That trim() should be found and killed. ;)

And yes, the checks should probably be centralized more than they already are.

charlottethewebb wrote:

while we're on this subject can we also normalize all file extensions to three letters, lowercase?

i'd argue that allowing "Foobar.jpg", "Foobar.JPG", "Foobar.JPEG", etc. to be different files is a bug rather than a helpful feature.

what's that 2^3 + 2^4 = twenty-four possible files named "Foobar" in the same format? More?

course i probably have to File A Separate Ticket For This.

herd wrote:

(In reply to comment #3)

while we're on this subject can we also normalize all file extensions to three
letters, lowercase?

.djvu ?

charlottethewebb wrote:

.djvu ?

Wikipedia says:

Filename extension .djvu, .djv

Don't know which one is preferred, or whether we even allow this format, but if we do we should pick one suffix to favor and normalize the other to it.

Or maybe djvu is just a double entendre meaning that my complaint is a duplicate of some other bug (probably is, didn't check, never had any luck with the search anyway).

File a separate bug for that, please. :)

(Note we do normalize extensions for deleted file storage. It's not necessarily the 3-letter variant that's normal [if a 3-letter variant exists!] but there is a preferred variant.)

herd wrote:

(In reply to comment #5)

Or maybe djvu is just a double entendre meaning that my complaint is a
duplicate of some other bug (probably is, didn't check, never had any luck with
the search anyway).

Possibly a dupe of bug 4421 or bug 12992 (note these are alternate proposals to a similar resolution).

Also, Plz friend me (since we're turning this into a social networking site). (this is a joke)

Fixed in r44987.

*** Bug 16512 has been marked as a duplicate of this bug. ***