Page MenuHomePhabricator
Create Task
Maniphest T187725

update texts for hastemplate form fields
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To
None
Authored By
Charlie_WMDE
Feb 19 2018, 2:04 PM
Tags
Referenced Files
F13952646: Screenshot_20180222_181608.png
Feb 22 2018, 5:21 PM
F13906289: overallMock.png
Feb 20 2018, 1:34 PM
F13905489: hasTemplateInfotext.png
Feb 20 2018, 12:35 PM
F13880622: hasTemplateInfotext.png
Feb 19 2018, 2:05 PM
Subscribers
Aklapper
Charlie_WMDE
gerritbot
Lea_WMDE
• MichaelSchoenitzer_WMDE
• Tonina_Zhelyazkova_WMDE

Description

  • adapt infotext for hastemplate

hasTemplateInfotext.png (737×668 px, 123 KB)

TEXT FOR COPYING:

Pages with these templates:
Description: Searches for pages that contain exactly these templates.
Be aware of the following:

  • You can find transcluded templates (templates consisting of other templates).
  • The autosuggest function can only find templates which start the same way as your search e.g. a search for "com..." will suggest "commons" but not "nowcommons".

Help page: hastemplate
Syntax-equivalent in the normal search: Words in quotation marks with hastemplate: before them like `hastemplate:"missing information".
`

  • change labels to newest version

Screenshot_20180222_181608.png (694×1 px, 87 KB)

Details

SubjectRepoBranchLines +/-
Fix infobox textmediawiki/extensions/AdvancedSearchmaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

Charlie_WMDE created this task.Feb 19 2018, 2:04 PM
Restricted Application added projects: TCB-Team (now WMDE-TechWish), Design. · View Herald TranscriptFeb 19 2018, 2:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Charlie_WMDE added a subscriber: Lea_WMDE.Feb 19 2018, 2:05 PM
This comment was removed by Charlie_WMDE.
Charlie_WMDE moved this task from Incoming to WMDE-Design-Workboard Doing on the WMDE-Design board.Feb 19 2018, 3:14 PM
Charlie_WMDE edited projects, added WMDE-Design (WMDE-Design-Workboard Doing); removed WMDE-Design.
Charlie_WMDE moved this task from ToDo to doing on the WMDE-Design (WMDE-Design-Workboard Doing) board.Feb 19 2018, 3:27 PM
Charlie_WMDE mentioned this in T187197: [AdvancedSearch] Mock for deepcat, subpageOf and inLanguage integration.Feb 19 2018, 5:05 PM
Charlie_WMDE renamed this task from rework hastemplate functionality and infotext to rework infotexts anf labels.Feb 20 2018, 12:18 PM
Charlie_WMDE updated the task description. (Show Details)
Charlie_WMDE renamed this task from rework infotexts anf labels to rework infotexts and labels.Feb 20 2018, 12:35 PM
Charlie_WMDE updated the task description. (Show Details)
Charlie_WMDE renamed this task from rework infotexts and labels to rework infotexts, default selection and labels.Feb 20 2018, 1:34 PM
Charlie_WMDE updated the task description. (Show Details)
Charlie_WMDE added a comment.Feb 20 2018, 1:37 PM

@Lea_WMDE this is done from my side

Charlie_WMDE mentioned this in T181583: The default for the file type field should be "Select file type".Feb 20 2018, 1:43 PM
Lea_WMDE renamed this task from rework infotexts, default selection and labels to update texts.Feb 21 2018, 7:57 AM
Lea_WMDE triaged this task as Medium priority.
Lea_WMDE updated the task description. (Show Details)
Lea_WMDE moved this task from TODO/Doing (Design) to Tickets ready for pickup on the Advanced-Search board.Feb 21 2018, 8:01 AM
Charlie_WMDE moved this task from doing to done on the WMDE-Design (WMDE-Design-Workboard Doing) board.Feb 21 2018, 9:28 AM
• Tonina_Zhelyazkova_WMDE set the point value for this task to 1.Feb 21 2018, 1:42 PM
Lea_WMDE added a comment.Feb 21 2018, 2:30 PM

@Charlie_WMDE could you add a mastermock that does not have the text cut off? And should all field labels have ":" at the end?
Similarly, this ticket has "Syntax-Equivalent" but all deployed infotexts say "syntax-equivalent". Should this be changed here, too?

Lea_WMDE moved this task from Tickets ready for pickup to TODO/Doing (Design) on the Advanced-Search board.Feb 21 2018, 2:36 PM
Charlie_WMDE added a comment.Feb 22 2018, 4:07 PM

@Lea_WMDE I'm sorry about the cut off parts. This is still something that happens in draw.io and I have not figured out how to solve this yet. I have already blocked some time next week to transfer the current mocks to figma, which is the new mocking software we use. After that those remnants should be gone. Until then I hope you can work with the ones we have.

Just to clarify: Each of the labels has a colon behind it.
Syntax-equivalent: the mock is correct, the text for copying was not. I changed it.

Charlie_WMDE updated the task description. (Show Details)Feb 22 2018, 4:07 PM
Charlie_WMDE updated the task description. (Show Details)Feb 22 2018, 5:21 PM
Lea_WMDE added a comment.Feb 23 2018, 11:24 AM

@Charlie_WMDE thanks Charlie!

Lea_WMDE moved this task from TODO/Doing (Design) to Tickets ready for pickup on the Advanced-Search board.Feb 23 2018, 11:24 AM
Lea_WMDE renamed this task from update texts to update texts for hastemplate form fields.Mar 14 2018, 9:21 AM
Lea_WMDE added a project: WMDE-FUN-Sprint-2018-04-18.Apr 18 2018, 1:25 PM
• Tonina_Zhelyazkova_WMDE moved this task from Tickets ready for pickup to In FUN sprint on the Advanced-Search board.Apr 20 2018, 12:52 PM
• Tonina_Zhelyazkova_WMDE claimed this task.Apr 23 2018, 9:43 AM
• Tonina_Zhelyazkova_WMDE moved this task from Todo to Doing on the WMDE-FUN-Sprint-2018-04-18 board.
• Tonina_Zhelyazkova_WMDE added a comment.Apr 23 2018, 10:17 AM

@Charlie_WMDE In this mock, the part with "Help page: hastemplate" has the link word not capitalized. Is this intentional, because on master it's "Help page: Hastemplate"?
We have other Help page text that is capitalized: "Full text search", "Words, phrases, and modifiers", "Intitle and incategory", "Inlanguage" and the rest is lowercase.
#nitpicking

gerritbot subscribed.Apr 23 2018, 10:34 AM

Change 428307 had a related patch set uploaded (by Tonina Zhelyazkova; owner: Tonina Zhelyazkova):
[mediawiki/extensions/AdvancedSearch@master] Update hastemplate infobox content

https://gerrit.wikimedia.org/r/428307

gerritbot added a project: Patch-For-Review.Apr 23 2018, 10:34 AM
• Tonina_Zhelyazkova_WMDE mentioned this in rEASR91a80d4e0e9c: [Do not merge] Update hastemplate infobox content.Apr 23 2018, 10:36 AM
• Tonina_Zhelyazkova_WMDE mentioned this in rEASR7222a8baf3ce: Update hastemplate infobox content.
• Tonina_Zhelyazkova_WMDE removed • Tonina_Zhelyazkova_WMDE as the assignee of this task.Apr 23 2018, 11:02 AM
• Tonina_Zhelyazkova_WMDE moved this task from Doing to Review on the WMDE-FUN-Sprint-2018-04-18 board.
• Tonina_Zhelyazkova_WMDE subscribed.
Charlie_WMDE added a comment.Apr 23 2018, 11:53 AM

@Tonina_Zhelyazkova_WMDE you're absolutely right. Consistent capitalization is definitely my weakness.

The should all be capitalized I'd say.

I'm sorry that I didn't see it earlier myself. I know it's super annoying to make little text changes later on. Do you need me to make an extra ticket for the other ones?

• Tonina_Zhelyazkova_WMDE added a comment.EditedApr 23 2018, 12:01 PM

@Charlie_WMDE no, that's ok, I'll link the change into this ticket.
Just to make it clear - all "Help page" links in the infoboxes should start with an uppercase letter, right?

Charlie_WMDE added a comment.Apr 23 2018, 12:04 PM

@Tonina_Zhelyazkova_WMDE yes, that would be great! thank you :)

• Tonina_Zhelyazkova_WMDE mentioned this in rEASR30c8fc0cbdb2: [Do not merge] Update hastemplate infobox content.Apr 23 2018, 12:17 PM
• Tonina_Zhelyazkova_WMDE mentioned this in rEASR33178a00d7c4: Update hastemplate infobox content.Apr 25 2018, 8:09 AM
• Tonina_Zhelyazkova_WMDE mentioned this in rEASR9980a4f53dbc: Update hastemplate infobox content.
• Tonina_Zhelyazkova_WMDE mentioned this in rEASR8fc2d1e06127: Update hastemplate infobox content.Apr 27 2018, 9:56 AM
• Tonina_Zhelyazkova_WMDE mentioned this in rEASRb4c934d816de: Update hastemplate infobox content.Apr 27 2018, 10:00 AM
• Tonina_Zhelyazkova_WMDE moved this task from Review to Test on the WMDE-FUN-Sprint-2018-04-18 board.Apr 27 2018, 10:18 AM
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)).Apr 27 2018, 11:00 AM
• MichaelSchoenitzer_WMDE subscribed.Apr 30 2018, 11:11 AM

The heading of the info-text as well as the label of the inputs still shows singular "Only pages with this template", "Page in this category:", "Only pages with this template".

I think they should be plural as they are in the mokups in this ticket.

gerritbot added a comment.Apr 30 2018, 11:33 AM

Change 429771 had a related patch set uploaded (by Tonina Zhelyazkova; owner: Tonina Zhelyazkova):
[mediawiki/extensions/AdvancedSearch@master] Fix infobox text

https://gerrit.wikimedia.org/r/429771

• Tonina_Zhelyazkova_WMDE mentioned this in rEASR973235d81b4d: Fix infobox text.Apr 30 2018, 11:34 AM
gerritbot added a comment.Apr 30 2018, 11:54 AM

Change 429771 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Fix infobox text

https://gerrit.wikimedia.org/r/429771

• Tonina_Zhelyazkova_WMDE moved this task from Test to Deploy on the WMDE-FUN-Sprint-2018-04-18 board.Apr 30 2018, 12:00 PM
• Tonina_Zhelyazkova_WMDE moved this task from Deploy to Done on the WMDE-FUN-Sprint-2018-04-18 board.May 2 2018, 7:54 AM
Charlie_WMDE added a comment.May 3 2018, 11:53 AM

Thank you!

Lea_WMDE closed this task as Resolved.May 30 2018, 10:33 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL