Page MenuHomePhabricator

Jump to top is purposely hidden on iPhone
Open, Stalled, LowPublic

Description

Background

The back to top button is not appearing on certain browers/deviced, reported by @dr0ptp4kt

Steps to recreate (iPhone 7 plus, Safari):

  1. Enable beta mode
  2. Go to any article
  3. Scroll

Expected:
Back to top button appearing
Observed:
Back to top button does not appear

Note: have not been able to reproduce on Android

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 20 2018, 4:42 PM
ovasileva triaged this task as Normal priority.Feb 20 2018, 4:42 PM
ovasileva moved this task from Incoming to Needs Prioritization on the Readers-Web-Backlog board.

It appears that the decision was made not to show the back-to-top button on iOS because it was misaligned.
https://phabricator.wikimedia.org/T141598
I don't think the reasoning behind this decision was justified, the task just mentions that it looked bad.
If the feature functions well on iOS, I think fixing it's appearance would be more desirable than disabling it.

@Jdrewniak - agreed. Let's fix it. Do we know if there's anything we can do about the alignment?

So I just enabled this feature locally and looked at it on the iOS simulator.

On iOS 9 and up, it looks fine. On iOS 8 (which is the last grade A version of iOS we support) it seems to be a little off. In my opinion, the issue seems quite fixable.

iOS 11iOS 9iOS 8

I'll also add that as these phones get bigger, the scroll-to-top button get more useful.

Looks good to me - I'd say let's do it. It's also clearly a beta feature, so I'm not as worried about the alignment, especially if it's just iOS 8

Change 413158 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[mediawiki/skins/MinervaNeue@master] Enabling back-to-top button on iOS

https://gerrit.wikimedia.org/r/413158

Jdrewniak set the point value for this task to 1.
Restricted Application added a project: Readers-Web-Backlog. · View Herald TranscriptFeb 21 2018, 1:31 PM

The solution here was quite easy, so I went ahead and pointed, claimed, and submitted the patch.

Adding a vendor prefix to the css transform was enough to fix the positioning on iOS8.

Jdlrobson added a subscriber: Jdlrobson.

The iOS browser already provides this feature- clicking the address bar jumps you back to the top.

We experienced a bunch of problems with position fixed relating to this feature in older versions of iOS. The icon alignment issue flagged to us that the feature had been written for android and only tested on android. As a result given the uncertain future of the feature we purposely disabled it for iOS

If we want to restore this feature on iOS we really should give it more extensive testing on older devices.

That said Nirzar has expressed a desire to rewrite the entire feature so I'm not sure what we gain by adding iOS support other than maintenance cost. My advice would be to decline but let's chat about it tomorrow.

See https://phabricator.wikimedia.org/T149690 for the proposed rewrite.

Change 413158 abandoned by Jdrewniak:
Enabling back-to-top button on iOS

https://gerrit.wikimedia.org/r/413158

After yesterday's conversations, it might make more sense to decline as well. Given that we might have some capacity for smaller projects, I can see us tackling the rewrite in the near future. Let's confirm during standup today.

I think decline is fine, but the verbiage in the settings screen is then still confusing for iOS users and there's the question of consistency for multidevice users (cross-platform mobility users do exist, although anecdotally their somewhat rare) - how to resolve that? Many iOS users are unaware of the jump to top feature inbuilt into iOS apps such as Safari.

Jdlrobson reassigned this task from Jdrewniak to Nirzar.Feb 26 2018, 6:14 PM

Nirzar what are your thoughts on this?

Nirzar added a comment.EditedFeb 26 2018, 8:46 PM

my thoughts... I can't separate the end goal from this task so I will just express the end goal here -

  • We fix the styling of the sticky button
  • We promote it to stable for 50% for all platforms (ios/android)
  • Check the pageinteractions / timespent / session depth for these two buckets (can't use beta vs non beta for this)
  • Decide to promote it to 100%

as far as this task goes, I would ask, what is more easier? hiding this option from list of beta features available only for iOS or disabling hiding this button for iOS?

as far as this task goes, I would ask, what is more easier? hiding this option from list of beta features available only for iOS or disabling hiding this button for iOS?

Hiding from the list of beta features is easiest.
If we have plans to have this button on iOS and ship this feature to 50% of platforms as is then it may be worth investing time in showing it on iOS (or not?).

If the plan is to rewrite the button per T149690 then it makes sense to do that first and make enabling this on iOS as part of that goal.

@Nirzar and @ovasileva maybe we should sync in product planning over this?

@Nirzar and @ovasileva maybe we should sync in product planning over this?

sounds good. I was just throwing a possible future for this feature, let's chat tomorrow about this

Jdlrobson removed the point value for this task.

In goals meeting we were told that we are working on some new flows for this feature. We'll revisit this later when those are done.

Jdlrobson renamed this task from Back to top button not appearing on some browsers to Jump to top is purposely hidden on iPhone.Jun 8 2018, 7:29 PM
alexhollender lowered the priority of this task from Normal to Low.May 22 2019, 1:53 AM
alexhollender moved this task from Needs analysis to Queue on the Readers-Web-Backlog (Design) board.
alexhollender added a subscriber: alexhollender.

@ovasileva given our revised plan (T197718) I'm wondering if it would make sense to close this task, as well as T196641?

ovasileva changed the task status from Open to Stalled.May 22 2019, 8:08 AM

@ovasileva given our revised plan (T197718) I'm wondering if it would make sense to close this task, as well as T196641?

I think it might be a good idea to wait until T197718 is done. How about we leave it open but mark it as stalled?