Page MenuHomePhabricator
Create Task
Maniphest T187853

Wikilove generates broken image thumbnails
Closed, ResolvedPublic
Actions

Description

It currently creates images with this:
[[File:File-Boer Goat (8742860752).jpg|left|150px]]

It should be this:
[[File:Boer Goat (8742860752).jpg|left|150px]]

Examples at:
https://wikitech.wikimedia.org/wiki/User_talk:Example-user-a
https://www.mediawiki.org/wiki/Topic:U80ivmoabgx8ty1d

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/WikiLovemaster+1 -1normalizeFilename: Fix 'File:Foo.jpg' input case
Customize query in gerrit

Related Objects

Event Timeline

Quiddity created this task.Feb 21 2018, 3:07 AM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptFeb 21 2018, 3:07 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Quiddity triaged this task as Unbreak Now! priority.Feb 21 2018, 3:07 AM
Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptFeb 21 2018, 3:07 AM
Legoktm added subscribers: Esanders, Fomafix.Feb 21 2018, 6:11 AM
• pmiazga added a subscriber: • pmiazga.Feb 21 2018, 10:58 AM
Fomafix added a comment.Feb 21 2018, 11:42 AM

07ca2020b3ecd1364a7921a4b82ab38a6270475e is responsible for this bug.

normalizeFilename('foo')

returns before this change "File:foo" and

returns after this change "foo".

Aklapper added a project: Regression.Feb 21 2018, 1:48 PM

CC'ing @Esanders as author

Esanders added a comment.Feb 22 2018, 5:40 PM

Appears to only affect the click-thumbnail-to-select mode (kittens & goats), but not the others. Looking.

Elitre awarded a token.Feb 22 2018, 5:42 PM
gerritbot added a subscriber: gerritbot.Feb 22 2018, 5:48 PM

Change 413419 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/WikiLove@master] normalizeFilename: Fix 'File:Foo.jpg' input case

https://gerrit.wikimedia.org/r/413419

gerritbot added a project: Patch-For-Review.Feb 22 2018, 5:48 PM
Esanders awarded a token.Feb 22 2018, 6:18 PM
gerritbot added a comment.Feb 22 2018, 6:57 PM

Change 413419 merged by jenkins-bot:
[mediawiki/extensions/WikiLove@master] normalizeFilename: Fix 'File:Foo.jpg' input case

https://gerrit.wikimedia.org/r/413419

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)).Feb 22 2018, 7:00 PM
greg added a subscriber: greg.Feb 27 2018, 6:42 AM

An UBN! with a merged patch for 4 days and no backport?

Liuxinyu970226 awarded a token.Feb 27 2018, 2:57 PM
greg added a comment.Mar 1 2018, 11:17 PM

@Esanders / @Catrope what should we do here?

Esanders added a comment.Mar 1 2018, 11:46 PM

It's not really my project to say... maybe our wikis can go without kittens and goats for another few days?

matmarex closed this task as Resolved.Mar 5 2018, 7:46 PM
matmarex assigned this task to Esanders.
matmarex added a subscriber: matmarex.

By now, this fix has been deployed with the normal train.

Liuxinyu970226 removed a subscriber: Liuxinyu970226.Mar 6 2018, 2:05 AM
kaldari added a subscriber: kaldari.Mar 6 2018, 7:04 PM

I protected all the goats from being moved further.

Ladsgroup removed a project: Patch-For-Review.May 21 2019, 9:33 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL