Page MenuHomePhabricator

Don't allow revdel/suppression on Special:Log/abusefilterprivatedetails
Open, Stalled, LowPublic

Description

Similar to what happens to Special:Log/suppress; entries in that log should not be deletable/suppresable. The log is already private.

Event Timeline

I'm looking at this. The main problem is that the core determines whether to add the checkboxes basing on the row log type, here. Since (of course) abusefilterprivatedetails is a stand-alone log not included in suppress log, this means that it's not straightforward to add a non-deletable log without changing the core.

Change 446002 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Make abusefilterprivatedetails log unhideable

https://gerrit.wikimedia.org/r/446002

Wouldn't it be useful to allow specifying values for this global in extension.json directly?

Aklapper changed the task status from Open to Stalled.Jul 2 2022, 10:13 AM
Aklapper edited projects, added: Patch-Needs-Improvement; removed: Patch-For-Review.

Stalled per last comment plus patch needs rework to pass Jenkins

Change 446002 abandoned by Daimona Eaytoy:

[mediawiki/extensions/AbuseFilter@master] Make abusefilterprivatedetails log unhideable

Reason:

https://gerrit.wikimedia.org/r/446002