Page MenuHomePhabricator

3D extension throws error if $wg3dProcessEnviron not manually defined
Closed, ResolvedPublic

Description

The 3D extension shells out and uses an environment array from $wg3dProcessEnviron, however there's no default set so it ends up being NULL. This then throws an error in wfShellExec, as reported on https://www.mediawiki.org/wiki/Topic:U53nq77l9mtcyji4

Recommendation: set a default value in extension.json.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 413196 had a related patch set uploaded (by Brion VIBBER; owner: Brion VIBBER):
[mediawiki/extensions/3D@master] Set a default value for $wg3dProcessEnviron

https://gerrit.wikimedia.org/r/413196

Ramsey-WMF added a subscriber: Ramsey-WMF.

Thanks, Brion. Looks like the patch will do the job, assigning to Matthias for double-checking/awareness.

Change 413196 merged by jenkins-bot:
[mediawiki/extensions/3D@master] Set a default value for $wg3dProcessEnviron

https://gerrit.wikimedia.org/r/413196

Ramsey-WMF triaged this task as Medium priority.Feb 23 2018, 6:43 PM
Ramsey-WMF moved this task from Untriaged to Tracking on the Multimedia board.