Page MenuHomePhabricator
Create Task
Maniphest T187902

3D extension throws error if $wg3dProcessEnviron not manually defined
Closed, ResolvedPublic
Actions

Description

The 3D extension shells out and uses an environment array from $wg3dProcessEnviron, however there's no default set so it ends up being NULL. This then throws an error in wfShellExec, as reported on https://www.mediawiki.org/wiki/Topic:U53nq77l9mtcyji4

Recommendation: set a default value in extension.json.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/3Dmaster+2 -1Set a default value for $wg3dProcessEnviron
Customize query in gerrit

Related Objects

Event Timeline

brion created this task.Feb 21 2018, 4:18 PM
Restricted Application added a project: Multimedia. · View Herald TranscriptFeb 21 2018, 4:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a subscriber: gerritbot.Feb 21 2018, 4:51 PM

Change 413196 had a related patch set uploaded (by Brion VIBBER; owner: Brion VIBBER):
[mediawiki/extensions/3D@master] Set a default value for $wg3dProcessEnviron

https://gerrit.wikimedia.org/r/413196

gerritbot added a project: Patch-For-Review.Feb 21 2018, 4:51 PM
brion mentioned this in rETHR658a815002d3: Set a default value for $wg3dProcessEnviron.Feb 21 2018, 4:53 PM
• Ramsey-WMF assigned this task to matthiasmullie.Feb 21 2018, 7:24 PM
• Ramsey-WMF added a subscriber: • Ramsey-WMF.

Thanks, Brion. Looks like the patch will do the job, assigning to Matthias for double-checking/awareness.

gerritbot added a comment.Feb 22 2018, 9:10 AM

Change 413196 merged by jenkins-bot:
[mediawiki/extensions/3D@master] Set a default value for $wg3dProcessEnviron

https://gerrit.wikimedia.org/r/413196

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)).Feb 22 2018, 10:00 AM
• Ramsey-WMF triaged this task as Medium priority.Feb 23 2018, 6:43 PM
• Ramsey-WMF moved this task from Untriaged to Tracking on the Multimedia board.
matthiasmullie closed this task as Resolved.Mar 19 2018, 11:36 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL