Page MenuHomePhabricator

Usernames with apostrophes are not well escaped in edit summaries
Closed, ResolvedPublic

Description

Problem:
Apparently, there are usernames that contain apostrophes. The apostrophe gets escaped when used in an edit summary (right-hand side).

List of steps to reproduce (step by step, including full links if applicable):

  • revert an edit of a user with an apostrophe in their user name
  • view the diff of the revert

What happens?:

  • user name is shown wrong in the edit summary that was automatically generated for the revert
  • user name is not linked correctly in the edit summary that was automatically generated for the revert

What should have happened instead?:

  • user name is shown and linked without encoding issue

Browser information, screenshots/mockups, other information, etc. (if applicable):
Screenshot from an example diff with broken encoding in the summary:

image.png (126×785 px, 32 KB)

Acceptance criteria (optional):

  • apostrophes in user names are handled without encoding issues when reverting an edit of a user with an apostrophe in their user name

Notes:

  • We know this is stemming from wikibase, as the message key used for the edit summary is wikibase-entity-summary-restore from Wikibase repo

Event Timeline

thiemowmde triaged this task as Medium priority.Feb 21 2018, 6:25 PM
thiemowmde moved this task from incoming to ready to go on the Wikidata board.
thiemowmde subscribed.

Seems to be closely related to T187755: Double quotes in sitelink are displayed as HTML entity in automated edit summary. Could potentially be the same cause, but should be tracked separately.

Hello, is this issue still open? Can I take it up? I'm a new contributor looking for first bugs.

aniluom subscribed.
This comment was removed by aniluom.

Change 832978 had a related patch set uploaded (by Hasan Akgün (WMDE); author: Hasan Akgün (WMDE)):

[mediawiki/core@master] Unescape double and single qoutes while formatting comments.

https://gerrit.wikimedia.org/r/832978

Change 832978 abandoned by Hasan Akgün (WMDE):

[mediawiki/core@master] Unescape double and single qoutes while formatting comments.

Reason:

I will try to solve this on Wikibase instead of MediaWiki core

https://gerrit.wikimedia.org/r/832978

Change 833014 had a related patch set uploaded (by Hasan Akgün (WMDE); author: Hasan Akgün (WMDE)):

[mediawiki/extensions/Wikibase@master] Unescape double and single qoutes while formatting auto-comments.

https://gerrit.wikimedia.org/r/833014

Change 833014 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Unescape double and single qoutes while formatting auto-comments.

https://gerrit.wikimedia.org/r/833014