Allow cross-slot access during HTML rendering.
Open, MediumPublic
Actions

Assigned To

None

Authored By

	daniel
	Feb 21 2018, 7:57 PM

Description

When generating a ParserOutput object for the content of one slot (via ContentHandler::getParserOutput), it should be possible to access the Content of other slots in the same revision, to allow cross-slot data access (e.g. transcluding information from some auxiliary slot into the output of the main slot). This should work for atomic edits too: when previewing an edit that changes slots X and Y, and the content of slot X uses parts of Y, the new content of Y should be visible in the rendering of X (as well as in the combined rendering of all slots).

An initial idea is to pass RevisionSlots (including inherited slots, after PST) to ContentHandler::getParserOutput. The relevant code is in WikiPage::prepareContentForEdit (resp. PageUpdater::prepareContentForEdit).

Note: This does not block SDC General, since SDC doesn't use atomic edits, and Wikibase doesn't rely on MediaWiki's transclusion mechanism. For cross-slot access as needed by SDC, see T194730: Ensure that Wikibase data access to MediaInfo on file description pages works with MCR .

Related Objects
Search...

Status	Subtype	Assigned	Task
Declined		dchen	T118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
Open		None	T115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
Open		None	T115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
Duplicate		None	T115864 Figure out if the description of the image can be used as the caption on-wiki
Open	Feature	None	T53032 When inserting an image, set its caption by default to be the Commons image description
Open	BUG REPORT	None	T12863 Links on commons upload summaries do not link to commons
Open		None	T5498 Image history is confusing
Stalled		None	T96384 Integrate file revisions with description page history
Open	Feature	None	T39534 Wikimedia Commons should support searching by color
Duplicate		None	T39535 Wikimedia Commons should support filtering by color
Resolved		None	T19503 Provide metadata support on Wikimedia Commons
Open		None	T122038 Moving/Deleting a video file does not move/delete subtitles files, nor does it inform the file mover of their existence
Open		None	T135221 Make TimedText content an integral part of the File page
Open	Feature	None	T2167 Use a dedicated interface for adding meta-data like interwiki links, rather than wikitext
Open		None	T132072 Integrate page meta-data as a new content model revision slot for consistency and atomicity
Resolved		None	T51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
Resolved		None	T68108 [Epic] Store media information for files on Wikimedia Commons as structured data
Open	Feature	None	T14963 allow per-page exceptions to spam blacklist
Open		None	T203157 Make the spam whitelist its own slot
Open	Feature	None	T56140 Move TemplateData to its own JSON-content namespace and associate with Template-namespace, or to its own TemplateData content model and revision slot
Stalled		None	T174043 Deploy Multi-Content Revisions
Open		None	T174022 Implement multi-content revisions
Open		None	T189220 Ensure that relevant extensions are MCR-aware
Resolved		daniel	T194037 Track dependencies for multiple Content objects per page
Resolved		daniel	T194038 Introduce ContentHandler::getSecondaryDataUpdates to replace Content::getSecondaryDataUpdates
Invalid		Tgr	T194049 Introduce SlotRenderingProvider
Resolved		daniel	T190063 Tracking dependencies for multiple Content objects per page (MCR)
Resolved		Tgr	T194043 Replace usages of Content::getSecondaryDataUpdates
Resolved		Tgr	T196653 Test MCR Storage Layer Patches
Resolved		Tgr	T192306 Create MCR test wiki on WM Cloud
Resolved		Bstorm	T194239 Request creation of mcr-dev VPS project
Resolved		CCicalese_WMF	T196082 npm install for selenium tests not working on labs-vagrant
Resolved		edwardspec	T205982 MCR: replace PageContentSave hook: must have a hook that receives all slots (for edit-intercepting extensions like Moderation)
Open		None	T195779 MCR support in ORES
Resolved		awight	T201332 ORES feature extraction triggers new MCR-related deprecation warning
Open		None	T191795 Support MCR in mobile
Open		None	T200687 MCR support in TemplateStyles
Open		None	T187935 Allow cross-slot access during HTML rendering.
Open		None	T201848 Make DifferenceEngine callers pass revisions, not contents
Open		None	T202763 Update extensions which customize content diff rendering
Open		None	T117279 [EPIC] Core should provide inline diffs as well as side by side (Move InlineDifferenceEngine into core / remove MobileDiff)
Resolved		ovasileva	T101796 MobileDiff appears strangely empty if previous revision is hidden
Stalled		None	T222562 Special:MobileDiff doesn't correctly handle diff=0 if the diff would cover multiple revisions
Resolved		Ammarpad	T224430 Improve appearance of Special:MobileDiff when looking for invalid revision (Maybe because it's deleted)
Open		None	T194830 Refactor DifferenceEngine
Stalled		None	T238331 Option for hiding changes should be added to AMC diff display
Resolved		Jdlrobson	T240608 Standardise a control for switching diff types from side by side to inline/visual
Resolved		phuedx	T240622 [Technical debt payoff] Remove InlineDiffFormatter and InlineDifferenceEngine from MobileFrontend
Open		Jdlrobson	T240624 Style desktop Minerva diff page to look like Special:MobileDiff
Resolved		ovasileva	T242310 Regression: issues with MobileDiff
Resolved		• marcella	T242351 HTML for VisualDiff mode button appears in mobile diff pages (disabled by hack)
Resolved		matmarex	T244673 VisualDiff feature on mobile has an inconsistent style/layout
Resolved	BUG REPORT	Esanders	T245172 VisualDiff toggle buttons appear in mobile when the relevant page doesn't have wikitext content model
Resolved		ovasileva	T243783 MobileDiff drops whitespaces from edits
Resolved		ovasileva	T243235 Regression: Desktop diff styles for moved paragraphs load alongside mobile
Resolved		Jdlrobson	T171726 MobileDiff with inconsistent linebreaks within words
Open		None	T199307 Determine treatment for empty lines in diffs
Resolved		• jkroll	T197729 wikidiff2 creating ins and del elements with single empty character element
Stalled	Feature	None	T298174 Mobile web diffs should show change tags
Open		None	T218428 Mobile diff is not clear about move direction
Stalled		None	T191706 It's not possible to undo/rollback edits from diff on Mobile
Open		None	T347779 Show bytes added, editor groups and edit count on diff pages
Open		None	T347780 Include previous and next links outside the diff columns
Resolved		daniel	T208767 Ensure that SpamBlacklist applies to the content of all MCR slots
Resolved		Jdforrester-WMF	T208769 Ensure that AbuseFilter applies to the content of all MCR slots
Resolved		daniel	T209291 Make AbuseFilter::revisionToString work across slots
Resolved		Jdforrester-WMF	T208770 Ensure TitleBlacklist applies when the context is an MCR page
Resolved		Jdforrester-WMF	T208771 Ensure ConfirmEdit applies when the context is an MCR page
Declined		None	T218096 Extension Duplicator needs to be updated due to MCR schema changes

Event Timeline

daniel triaged this task as Medium priority.Feb 21 2018, 7:57 PM

daniel created this task.

A straight forward approach to this would be passing RevisionSlots (including inherited slots, after PST) to ContentHandler::getParserOutput. The relevant code is in WikiPage::prepareContentForEdit (resp. PageUpdater::prepareContentForEdit).

Note that there's plenty of other code that calls Content::getParserOutput().

Chances are the better method for doing it is to go via Parser::fetchCurrentRevisionOfTitle(), or directly through ParserOptions::getCurrentRevisionCallback() if a Parser isn't available.

CCicalese_WMF moved this task from Inbox to Watching on the MediaWiki-Platform-Team-Archived board.Feb 27 2018, 2:39 AM

Lydia_Pintscher moved this task from incoming to monitoring on the Wikidata board.Apr 23 2018, 7:28 AM

CCicalese_WMF moved this task from Inbox to MCR-SDC Storage Layer - phase 1 on the Multi-Content-Revisions board.May 8 2018, 1:17 PM

CCicalese_WMF edited projects, added Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1); removed Multi-Content-Revisions.

daniel mentioned this in T194730: Ensure that Wikibase data access to MediaInfo on file description pages works with MCR .May 15 2018, 8:43 AM

daniel edited projects, added Multi-Content-Revisions; removed Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1), SDC General, Wikidata.May 15 2018, 8:50 AM

daniel updated the task description. (Show Details)

CCicalese_WMF edited projects, added Core-Platform-Team-Old; removed MediaWiki-Platform-Team-Archived.Jul 12 2018, 12:14 AM

CCicalese_WMF moved this task from Inbox to Watching on the Core-Platform-Team-Old board.

Tgr mentioned this in T200687: MCR support in TemplateStyles.Sep 24 2018, 8:49 PM

Tgr added a parent task: T200687: MCR support in TemplateStyles.

CCicalese_WMF edited projects, added Platform Team Legacy (Watching / External); removed Core-Platform-Team-Old.Oct 1 2018, 4:20 PM