Page MenuHomePhabricator
Create Task
Maniphest T187941

VisualEditor Hangs if Uploaded Image Manipulated with "Advanced Settings"
Closed, DuplicatePublic
Actions

Description

If an image is uploaded using VE with the Insert > Media option and the uploaded image is subsequently manipulated using "Advanced Settings," VisualEditor hangs once the save button has been pressed. The following output is found in the console:

load.php?...:1658 Uncaught TypeError: Cannot read property 'type' of null
    at VeDmMWImageModel.ve.dm.MWImageModel.insertImageNode (load.php?...:1658)
    at VeUiMWMediaDialog.handler (load.php?...:1697)
    at load.php?...:403
    at OO.ui.Process.execute (load.php?...:403)
    at VeUiMWMediaDialog.OO.ui.Dialog.executeAction (load.php?...:425)
    at VeUiMWMediaDialog.OO.ui.ProcessDialog.executeAction (load.php?...:433)
    at VeUiMWMediaDialog.OO.ui.Dialog.onActionClick (load.php?...:423)
    at OoUiActionSet.oo.EventEmitter.emit (load.php?...:130)
    at OoUiActionWidget.oo.EventEmitter.emit (load.php?...:130)
    at OoUiActionWidget.OO.ui.mixin.ButtonElement.onClick (load.php?...:161)

Related Objects

Event Timeline

bisongde created this task.Feb 21 2018, 8:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 21 2018, 8:38 PM
Esanders subscribed.Feb 28 2018, 2:20 PM

I can't reproduce, what exactly did you change in advanced settings?

Esanders updated the task description. (Show Details)Feb 28 2018, 2:22 PM
bisongde added a comment.Feb 28 2018, 2:26 PM

Any setting there will trigger for us. Toggling text wrap, changing page justification, etc. The media gets uploaded successfully but VE hangs if you click finish after selecting anything in the advanced settings menu.

Esanders added a comment.Feb 28 2018, 2:27 PM

Looks like a duplicate of T180521 from the stack trace.

Esanders closed this task as a duplicate of T180521: Can't add frameless images unless you insert them as thumbs first.Feb 28 2018, 2:27 PM
bisongde added a comment.Feb 28 2018, 2:50 PM
In T187941#4010404, @Esanders wrote:

Looks like a duplicate of T180521 from the stack trace.

I notice that you uploaded a patch in early January. Our VE version is current as of about two weeks ago. Is the patch you mention in that issue already in the master branch?

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits