Page MenuHomePhabricator

Impossible to edit page
Closed, ResolvedPublic

Description

When I validate an edit a page, I've the following message critical error :
Parse error: syntax error, unexpected ')' in /var/www/wiki/extensions/NewUserNotif/NewUserNotif.class.php on line 99

Impossible to access to Special:specialpages, too

Il faudrait arrêter de jouer aux apprentis sorciers.


Version: unspecified
Severity: blocker
OS: Linux
Platform: PC

Details

Reference
bz16796

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:23 PM
bzimport set Reference to bz16796.
bzimport added a subscriber: Unknown Object (MLST).

This appears to be a bug in the NewUserNotif extension, and not the MediaWiki core. Changing component accordingly.

Created attachment 5623
Patch

It appears to be an extraneous comma introduces in r45017.

Attached:

ayg wrote:

What version of PHP is this? If an extra comma causes fatal errors in some versions, we have a lot of code to clean up -- we use those all over the place.

I tested it with 5.2.6 (actually 5.2.6-0.1+b1 with Suhosin-Patch 0.9.6.2 from Debian). Extra commas are apparently allowed in arrays, but not in function parameter lists.

ayg wrote:

Ah, there wasn't enough context in the diff for me to see that that was a function call. That makes sense, then. Fixed in r45042.