Page MenuHomePhabricator

Unreachable code after return statement on Flow boards
Closed, DuplicatePublic

Description

On Flow boards, I see "unreachable code after return statement" in the browser console. The relevant code appears to look like this:

function
_createRevPagination($target) {
  return;
  if (!topicsData.links.pagination.fwd && !topicsData.links.pagination.rev) {
    return;
  }
  if (!topicsData.links.pagination.rev && topicsData.links.pagination.fwd) {
    topicsData.links.pagination.rev = $.extend(true, {
    }, topicsData.links.pagination.fwd, {
      title: 'rev'
    });
    topicsData.links.pagination.rev.url = topicsData.links.pagination.rev.url.replace('_offset-dir=fwd', '_offset-dir=rev');
  }
  $allRendered = $allRendered.add($(flowBoard.constructor.static.TemplateEngine.processTemplateGetFragment('flow_load_more.partial', {
    loadMoreObject: topicsData.links.pagination.rev,
    loadMoreApiHandler: 'loadMoreTopics',
    loadMoreTarget: scrollTarget,
    loadMoreContainer: scrollContainer,
    loadMoreTemplate: scrollTemplate
  })).children().insertBefore($target.first()));
}

Example page: https://sv.wikipedia.org/wiki/Wikipediadiskussion:Flow