Page MenuHomePhabricator
Create Task
Maniphest T188023

CodeSearch should search the VisualEditor core repo, not just VE-MW
Closed, ResolvedPublic
Actions

Description

https://gerrit.wikimedia.org/g/VisualEditor/VisualEditor is a git sub-module of https://gerrit.wikimedia.org/g/mediawiki/extensions/VisualEditor but seemingly not seen.

Details

ProjectBranchLines +/-Subject
labs/codesearchmaster+3 -0Include VisualEditor/VisualEditor as an "extension"
Customize query in gerrit

Related Objects

Event Timeline

Jdforrester-WMF created this task.Feb 22 2018, 5:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 22 2018, 5:40 PM
Legoktm added a subscriber: Legoktm.Feb 23 2018, 12:16 AM

I guess hound doesn't support submodules...we can just index VisualEditor/VisualEditor separately? It won't be the same exact version as the submodule but I assume those are kept in sync relatively frequently?

• bd808 added a subscriber: • bd808.Feb 23 2018, 12:27 AM

Filed upstream as https://github.com/etsy/hound/issues/277

Jdforrester-WMF added a comment.EditedFeb 23 2018, 12:27 AM

Yeah, indexing master of the submodule would be fine in this case.

gerritbot added a project: Patch-For-Review.Feb 24 2018, 8:40 AM
Legoktm closed this task as Resolved.Feb 24 2018, 8:46 AM
Legoktm claimed this task.

https://gerrit.wikimedia.org/r/414060

Done, https://codesearch.wmflabs.org/search/?q=VisualEditor&i=nope&files=&repos=

Legoktm updated the task description. (Show Details)Feb 24 2018, 8:46 AM
Legoktm mentioned this in rLCSH59a53d0ad529: Include VisualEditor/VisualEditor as an "extension".Feb 24 2018, 9:23 AM
Legoktm mentioned this in rLCSHe7828a23b909: Include VisualEditor/VisualEditor as an "extension".
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL