Page MenuHomePhabricator

Run parser tests with RemexHtml as the tidy implementation
Closed, ResolvedPublic

Description

RemexHtml is going to be the default tidy implementation soon, so we should run our parser tests with it.

This also happens to side-step the problem of libtidy in Debian stretch being updated and providing different results from Jessie and before.

Extensions that will probably need updates: https://codesearch.wmflabs.org/extensions/?q=html(%2Fphp)%3F%5C%2Btidy&i=nope&files=&repos=

Event Timeline

Legoktm created this task.Feb 24 2018, 6:29 AM

Change 409432 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@master] WIP: Use RemexHtml as the tidy implementation for parser tests

https://gerrit.wikimedia.org/r/409432

Change 414021 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/InputBox@master] Update parser tests for RemexHtml as tidy implementation

https://gerrit.wikimedia.org/r/414021

Change 414020 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Update parser tests for RemexHtml as tidy implementation

https://gerrit.wikimedia.org/r/414020

Change 415993 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/TimedMediaHandler@master] Update parser tests for RemexHtml as tidy implementation

https://gerrit.wikimedia.org/r/415993

Change 415993 merged by Jforrester:
[mediawiki/extensions/TimedMediaHandler@master] Update parser tests for RemexHtml as tidy implementation

https://gerrit.wikimedia.org/r/415993

Change 409432 merged by jenkins-bot:
[mediawiki/core@master] Use RemexHtml as the tidy implementation for parser tests

https://gerrit.wikimedia.org/r/409432

Change 414021 merged by jenkins-bot:
[mediawiki/extensions/InputBox@master] Update parser tests for RemexHtml as tidy implementation

https://gerrit.wikimedia.org/r/414021

Change 414020 merged by jenkins-bot:
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Update parser tests for RemexHtml as tidy implementation

https://gerrit.wikimedia.org/r/414020

Jdforrester-WMF added a subscriber: Jdforrester-WMF.

With all four patches merged, is this now Resolved?

Legoktm closed this task as Resolved.Mar 7 2018, 7:20 AM

Yep :-) I already announced this as part of https://lists.wikimedia.org/pipermail/wikitech-l/2018-March/089605.html and I'll call it out again when I flip the PHP 7 switch later this week.