Use user-select: none for line numbers in Gitiles
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Umherirrender
	Feb 24 2018, 11:41 AM

Description

When copy code from Gitiles the line numbers and a seperator space are included.
Doing the same from gerrit does not include the line number (the same for the old code column or the new code column)

Gerrit is setting -moz-user-select and similar on the line numbers.

Would be nice to report upstream. Thanks

Event Timeline

Umherirrender created this task.Feb 24 2018, 11:41 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 24 2018, 11:41 AM

You mean add that here https://github.com/google/gitiles/blob/7c07a4a68ece6009909206482e0728dbbf0be77d/resources/com/google/gitiles/static/base.css#L61 ?

Filled upstream at https://github.com/google/gitiles/issues/129

Paladox added a project: Upstream.Feb 24 2018, 1:57 PM

Paladox moved this task from Backlog to Reported Upstream on the Upstream board.Mar 2 2018, 10:18 PM

I cannot reproduce. Fixed?

Indeed, this looks fixed

Use user-select: none for line numbers in GitilesClosed, ResolvedPublicActions

Description

Event Timeline

Use user-select: none for line numbers in Gitiles
Closed, ResolvedPublic
Actions