site.interwiki_prefix() method always fails
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Xqt
	Feb 24 2018, 4:45 PM

Description

>>> import pwb, pywikibot as py
>>> s = py.Site()
>>> x = s.interwiki_prefix(s)

Traceback (most recent call last):
  File "<pyshell#3>", line 1, in <module>
    x = s.interwiki_prefix(s)
  File "pywikibot\site.py", line 969, in interwiki_prefix
    prefixes.update(self._interwikimap.get_by_url(url))
  File "pywikibot\site.py", line 712, in get_by_url
    return set(prefix for prefix, iw_entry in self._iw_sites
  File "pywikibot\site.py", line 713, in <genexpr>
    if iw_entry.url == url)
AttributeError: 'unicode' object has no attribute 'url'

Seems it was never used in 3,5 years.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	[bugfix] key, values pairs of dicts must be unpacked with items()	pywikibot/core	master	+4 -4
	[WIP][bugfix] Fix for _InterwikiMap.get_by_url() and interwiki_prefix()	pywikibot/core	master	+198 -24

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T101557 Improve Page.title
Open	None	T188157 Mediawiki.org interwiki is mw or mediawikiwiki, not mediawiki
Resolved	Xqt	T188179 site.interwiki_prefix() method always fails

Event Timeline

Xqt created this task.Feb 24 2018, 4:45 PM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptFeb 24 2018, 4:45 PM

Xqt triaged this task as Low priority.Feb 24 2018, 4:45 PM

Dvorapa awarded a token.Feb 24 2018, 4:51 PM

I noticed Pywikibot family reached 1000 currently openned tasks recently (currently showing this task as 1000th)! 🎉🎉🎉
(I wish the number of currently openned tasks was smaller)

Well there are some tasks which can be closed soon after reviewing patches. A patch for this comes soon ;)

Change 414116 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] Fix for _InterwikiMap.get_by_url() and interwiki_prefix()

https://gerrit.wikimedia.org/r/414116

gerritbot added a project: Patch-For-Review.Feb 24 2018, 6:07 PM

Dvorapa unsubscribed.Apr 30 2018, 10:01 AM

xSavitar moved this task from Backlog to Needs Review on the Pywikibot board.Nov 5 2018, 11:27 AM

Dvorapa merged a task: T222025: interwiki_prefix() does not seem to work.Apr 28 2019, 1:03 AM

Dvorapa subscribed.

Dvorapa mentioned this in T222026: Site.interwiki_prefix() should not fail if the interwiki is indirect.Apr 28 2019, 1:45 AM

Dvorapa mentioned this in T188157: Mediawiki.org interwiki is mw or mediawikiwiki, not mediawiki.

Dvorapa added a parent task: T188157: Mediawiki.org interwiki is mw or mediawikiwiki, not mediawiki.May 11 2019, 1:54 AM

Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Apr 2 2021, 9:40 AM

Now we have another but:

>>> import pywikibot
>>> s = pywikibot.Site()
>>> x = s.interwiki_prefix(s)
Traceback (most recent call last):
  File "<pyshell#2>", line 1, in <module>
    x = s.interwiki_prefix(s)
  File "C:\pwb\GIT\core\pywikibot\site\_apisite.py", line 161, in interwiki_prefix
    prefixes.update(self._interwikimap.get_by_url(url))
  File "C:\pwb\GIT\core\pywikibot\site\_interwikimap.py", line 90, in get_by_url
    return {prefix for prefix, iw_entry in self._iw_sites
  File "C:\pwb\GIT\core\pywikibot\site\_interwikimap.py", line 90, in <setcomp>
    return {prefix for prefix, iw_entry in self._iw_sites
ValueError: too many values to unpack (expected 2)

Solved with patch below

Change 677099 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [bugfix] key, values pairs of dicts must be unpacked with items()

https://gerrit.wikimedia.org/r/677099

gerritbot added a project: Patch-For-Review.Apr 6 2021, 7:46 AM

Restricted Application removed a project: Patch-Needs-Improvement. · View Herald TranscriptApr 6 2021, 7:46 AM

Change 677099 merged by jenkins-bot:

[pywikibot/core@master] [bugfix] key, values pairs of dicts must be unpacked with items()

https://gerrit.wikimedia.org/r/677099

Xqt mentioned this in rPWBC38b33c26824b: [bugfix] key, values pairs of dicts must be unpacked with items().Apr 6 2021, 7:53 AM

Xqt closed this task as Resolved.Apr 6 2021, 11:28 AM