Page MenuHomePhabricator

New wikitext editor should not display uneditable page content
Closed, ResolvedPublic1 Estimated Story Points

Description

Trying to edit https://hu.wikipedia.org/wiki/F%C3%A1jl:Momentum_Mozgalom_log%C3%B3.png with the new source editor (with a "show both tabs" setting, syntax highlighting enabled) ends up with this:

nwe-file.png (4×2 px, 1 MB)

which is pretty confusing. (It's made more confusing by the fact that T185184: Invisible text in new wikitext editor after large paste is still happening.) While this layout makes sense for VE, I don't think it does for the source editor. (Also, the loading process is pretty jarring, with the source code flashing in, then flashing out, the the image flashing in instead.)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Deskana set the point value for this task to 1.
Deskana subscribed.

That's really weird.

The FOUC is being caused by the temp wikitext editor which is a separate issue, but we need to think more carefully about what content we to show while VE is open on non-article pages, of which File pages are just one example. I don't want to just hack in one fix for this case. I'm also not sure there should be inconsistency between VE's visual and source modes; showing/hiding content as you switch between modes could be just as confusing.

Also worth noting that most images are on Commons, where VE is only a beta feature, so this is probably low priority.

Deskana lowered the priority of this task from Medium to Low.Aug 29 2018, 1:34 PM
Deskana moved this task from To Triage to Freezer on the VisualEditor board.
matmarex claimed this task.
matmarex subscribed.

This was fixed by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/441509 "Remove special handling for category and file pages".

Screenshots for reference: T194068#4618647