Page MenuHomePhabricator
Create Task
Maniphest T188268

Some metrics don't work in the topic selector
Closed, ResolvedPublic
Actions

Description

Metrics whose full name converted to kebab case doesn't match their key name don't work in the topic selector, as the questions assume they're always equal.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Corrected kebab case - key name mismatch of metrics in topic selectorSahil505analytics/wikistats2master+17 -17
Corrected kebab case - key name mismatch of metrics in topic selectorSahil505analytics/wikistats2master+1 -1
Customize query in gerrit

Related Objects

Event Timeline

• fdans created this task.Feb 26 2018, 4:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 26 2018, 4:34 PM
• Nuria edited projects, added: Analytics; removed: Analytics-Kanban.Mar 22 2018, 4:14 PM
• fdans triaged this task as High priority.Mar 26 2018, 4:20 PM
• fdans moved this task from Incoming to Wikistats Beta on the Analytics board.
gerritbot subscribed.Apr 1 2018, 9:49 PM

Change 423351 had a related patch set uploaded (by Sahil505; owner: Sahil505):
[analytics/wikistats2@master] Corrected kebab case - key name mismatch of metrics in topic selector

https://gerrit.wikimedia.org/r/423351

gerritbot added a project: Patch-For-Review.Apr 1 2018, 9:49 PM
sahil505 claimed this task.Apr 1 2018, 9:49 PM
sahil505 added subscribers: mforns, • Nuria.
gerritbot added a comment.Apr 3 2018, 7:51 PM

Change 423772 had a related patch set uploaded (by Sahil505; owner: Sahil505):
[analytics/wikistats2@master] Corrected kebab case - key name mismatch of metrics in topic selector

https://gerrit.wikimedia.org/r/423772

gerritbot added a comment.Apr 3 2018, 7:53 PM

Change 423351 abandoned by Sahil505:
Corrected kebab case - key name mismatch of metrics in topic selector

Reason:
Had some issue with merging, so abandoning this. Sorry.

https://gerrit.wikimedia.org/r/423351

gerritbot added a comment.Apr 3 2018, 9:57 PM

Change 423351 restored by Sahil505:
Corrected kebab case - key name mismatch of metrics in topic selector

https://gerrit.wikimedia.org/r/423351

gerritbot added a comment.Apr 3 2018, 9:59 PM

Change 423772 abandoned by Sahil505:
Corrected kebab case - key name mismatch of metrics in topic selector

Reason:
Corrected the previous patch. Phew :-)

https://gerrit.wikimedia.org/r/423772

gerritbot added a comment.Apr 3 2018, 10:08 PM

Change 423772 restored by Sahil505:
Corrected kebab case - key name mismatch of metrics in topic selector

https://gerrit.wikimedia.org/r/423772

gerritbot added a comment.Apr 3 2018, 10:09 PM

Change 423772 abandoned by Sahil505:
Corrected kebab case - key name mismatch of metrics in topic selector

https://gerrit.wikimedia.org/r/423772

sahil505 added a comment.Apr 3 2018, 10:15 PM

Sorry for all the above mess. Was facing some issues with merging/commits. Successfully restored.

sahil505 mentioned this in T189964: GSoC Proposal 2018 : [Analytics] Improvements to Wikistats2 front-end.Apr 5 2018, 4:51 AM
gerritbot added a comment.Apr 5 2018, 1:16 PM

Change 423351 merged by Mforns:
[analytics/wikistats2@master] Corrected kebab case - key name mismatch of metrics in topic selector

https://gerrit.wikimedia.org/r/423351

sahil505 added a project: Data-Engineering-Wikistats.Apr 12 2018, 10:40 PM
sahil505 added a project: Analytics-Kanban.May 1 2018, 9:42 PM
mforns closed this task as Resolved.May 7 2018, 8:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits