Page MenuHomePhabricator

RangeError: Maximum call stack size exceeded
Open, LowPublic

Description

https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2018.02.26/parsoid?id=AWHUBetBO7grxsPLp5Nw&_g=()

probably from

enwiki/User:Basement12/Recognised_Olympic_content/358734423
https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2018.02.26/parsoid?id=AWHUBetBO7grxsPLp5N1&_g=()

RangeError: Maximum call stack size exceeded
    at ParsoidLogger.Logger.log (/srv/deployment/parsoid/deploy-cache/revs/5fbabfc3cb8d18e813cd5397862bb7ed6f2acd20/src/lib/logger/Logger.js:111:11)
    at AsyncTokenTransformManager.emitChunk (/srv/deployment/parsoid/deploy-cache/revs/5fbabfc3cb8d18e813cd5397862bb7ed6f2acd20/src/lib/wt2html/TokenTransformManager.js:388:12)
    at TokenAccumulator._callParentCB (/srv/deployment/parsoid/deploy-cache/revs/5fbabfc3cb8d18e813cd5397862bb7ed6f2acd20/src/lib/wt2html/TokenTransformManager.js:1308:16)
    at TokenAccumulator.receiveToksFromChild (/srv/deployment/parsoid/deploy-cache/revs/5fbabfc3cb8d18e813cd5397862bb7ed6f2acd20/src/lib/wt2html/TokenTransformManager.js:1239:7)
    at AsyncTokenTransformManager.maybeSyncReturn (/srv/deployment/parsoid/deploy-cache/revs/5fbabfc3cb8d18e813cd5397862bb7ed6f2acd20/src/lib/wt2html/TokenTransformManager.js:838:3)
    at TokenAccumulator._callParentCB (/srv/deployment/parsoid/deploy-cache/revs/5fbabfc3cb8d18e813cd5397862bb7ed6f2acd20/src/lib/wt2html/TokenTransformManager.js:1308:16)
    at TokenAccumulator.receiveToksFromSibling (/srv/deployment/parsoid/deploy-cache/revs/5fbabfc3cb8d18e813cd5397862bb7ed6f2acd20/src/lib/wt2html/TokenTransformManager.js:1286:15)
    at AsyncTokenTransformManager.maybeSyncReturn (/srv/deployment/parsoid/deploy-cache/revs/5fbabfc3cb8d18e813cd5397862bb7ed6f2acd20/src/lib/wt2html/TokenTransformManager.js:838:3)
    at TokenAccumulator._callParentCB (/srv/deployment/parsoid/deploy-cache/revs/5fbabfc3cb8d18e813cd5397862bb7ed6f2acd20/src/lib/wt2html/TokenTransformManager.js:1308:16)
    at TokenAccumulator.receiveToksFromSibling (/srv/deployment/parsoid/deploy-cache/revs/5fbabfc3cb8d18e813cd5397862bb7ed6f2acd20/src/lib/wt2html/TokenTransformManager.js:1286:15)
    at AsyncTokenTransformManager.maybeSyncReturn (/srv/deployment/parsoid/deploy-cache/revs/5fbabfc3cb8d18e813cd5397862bb7ed6f2acd20/src/lib/wt2html/TokenTransformManager.js:838:3)
    at TokenAccumulator._callParentCB (/srv/deployment/parsoid/deploy-cache/revs/5fbabfc3cb8d18e813cd5397862bb7ed6f2acd20/src/lib/wt2html/TokenTransformManager.js:1308:16)
    at TokenAccumulator.receiveToksFromSibling (/srv/deployment/parsoid/deploy-cache/revs/5fbabfc3cb8d18e813cd5397862bb7ed6f2acd20/src/lib/wt2html/TokenTransformManager.js:1286:15)
    at AsyncTokenTransformManager.maybeSyncReturn (/srv/deployment/parsoid/deploy-cache/revs/5fbabfc3cb8d18e813cd5397862bb7ed6f2acd20/src/lib/wt2html/TokenTransformManager.js:838:3)
    at TokenAccumulator._callParentCB (/srv/deployment/parsoid/deploy-cache/revs/5fbabfc3cb8d18e813cd5397862bb7ed6f2acd20/src/lib/wt2html/TokenTransformManager.js:1308:16)
    at TokenAccumulator.receiveToksFromSibling (/srv/deployment/parsoid/deploy-cache/revs/5fbabfc3cb8d18e813cd5397862bb7ed6f2acd20/src/lib/wt2html/TokenTransformManager.js:1286:15)

same

https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2018.02.26/parsoid?id=AWHUBgkw-dBYI47OUSaU&_g=()

from

enwiki/Wikipedia:WikiProject_Olympics/802321753
https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2018.02.26/parsoid?id=AWHUBgkw-dBYI47OUSah&_g=()

Event Timeline

Arlolra created this task.Feb 26 2018, 9:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 26 2018, 9:38 PM
Arlolra triaged this task as High priority.Feb 26 2018, 9:38 PM

This seems to have been resolved by https://gerrit.wikimedia.org/r/#/c/412611/

@ssastry: but yes, fewer async paths and lower stack growth doesn't mean we fixed any other underlying problem.

Similarly to T186298, these are some very large pages that are being included,
https://zh.wikipedia.org/wiki/User:Derekleungtszhei/IE
https://en.wikipedia.org/wiki/Wikipedia:WikiProject_Olympics/Recognized_content
...

Arlolra lowered the priority of this task from High to Low.Feb 27 2018, 9:16 PM

Lowering the priority but leaving it open so that when we got looking for places to optimize it shows up.

Arlolra moved this task from Backlog to Performance on the Parsoid board.Feb 27 2018, 9:17 PM

There haven't been any incidents since deploying that patch so, for the moment, the low priority seems justified.